Food rebalance: Revenge of the soup #35433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only can in the game is 250mL, which is quite small, many cans are twice that size.
Previously 1 charge was 1.5 SPAM slices. I adjusted the calories, weight, charges, and volume to match 1 SPAM slice for more granularity.
Canned chicken was in a weird place; one charge was 1/4 the weight, calories, and volume of a chunk of meat, but only 2 charges were subbed in per chunk of meat in recipes. I quadrupled the charge size of canned chicken so that the comparison with meat is more intuitive.
Evaporated milk was far too light, and had too few calories. Adjusted calories to match evaporated skim milk as reported by USDA.
Canned corn had "copy-from": "corn" which didn't make a lot of sense, since cans of corn aren't exactly one ear of corn. I removed it, and reworked the item based on USDA data.
Condensed milk was listed twice, in drink.json and dairy.json, I elected to keep the one in dairy.json.
Mushroom soup had all sorts of problems. It was way too dense, the recipes used 8 cups of ingredient per cup of soup, and there was no recipe for 3L canning. These were all fixed, and the soup now defaults to 500mL cans when spawned by mapgen.
Broth recipes were inconsistent, and there was no recipe for canning in metal cans. These were fixed, and broth now spawns in 500 mL cans.
Vegetable soup ingredients were incredibly inconsistent. Fixed them, and veggy soup now spawns in 500 mL cans.
Meat soup ingredients were completely inconsistent, partially due to being restricted to 250 mL cans. They were redone to be consistent, and meat soup now spawns in 500 mL cans.
The canned fish soup recipe had a minor inconsistency due to being restricted to 250 mL cans. Fixed by putting fish soup in 500 mL cans.
Woods soup ingredients were inconsistent across its various recipes. Also, input volume was slightly too high for the output volume: Was (500 mL meat) + (500 mL broth) + (500 mL veggies) = 500 mL soup Now (250 mL meat) + (500 mL broth) + (500 mL veggies) = 500 mL soup Still seems a bit high, but it is now more consistent with other soups.
Human soup ingredients were inconsistent, partially due to being restricted to 250 mL tin cans.
All the changes made a couple recipes' calories not match their components' calories closely enough.
curstwist
added
Items: Food / Vitamins
|
On a related note. Would soup ever spawn in large tin cans? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Make canning recipes more consistent, and add 500 mL can"Purpose of change
Soups had a lot of consistency issues among their various canning recipes. My educated guess is that they were mainly caused by:
250 mL broth + 250 mL meat + 250 mL other = 250 mL (tin can)500 mL broth + 250 mL meat + 250 mL other = 500 mL (otherwise)One of the potential solutions to [1] was to add a new 500 mL steel can, and transfer soup canning recipes to these new cans. This made me realize that…
Describe the solution
"using"lists to help avoid future deviation.Describe alternatives you've considered
There is a slight cosmetic oddity due to the way that
"using"works that canning components (i.e. glass jar and 10 water) for the various soup recipes now appear at the bottom of the ingredient list. I wanted to fix this but couldn't find a good solution. One of the attempted solutions was implementing"using"lists for canning, and listing them before the food ingredients. It worked, but also resulted in recipes with water listed twice:instead of
This resulted in weird behavior where the recipe could be started with only 12 water, but a prompt would immediately stop you saying that you needed 10 more water to continue crafting. I didn't like this behavior so I rolled back the changes.
Testing
Additional context
I realize this PR is a bit sprawling. If I need to split it please let me know.