Remove limit of item count per tile

[BevapDin]

SUMMARY: Infrastructure "Remove item count per tile limit"

The crafting inventory already considers several dozen tiles around the character. It does not matter whether the games checks 1 tile with 10,000 items, or 10 tiles with 1,000, it has to iterate over all of them anyway.

And the item volume will add a natural limit anyway.

[KorGgenT]

wasn't the max item limit per tile added due to integer overflow via mods? and i know we don't strictly support mods, but not handling the error that could appear doesn't seem that great

[BevapDin]

wasn't the max item limit per tile added due to integer overflow via mods? and i know we don't strictly support mods, but not handling the error that could appear doesn't seem that great

What integer overflow? Under what circumstances? What has it to do with mods? Can you b´please be a bit more specific or link to the respective PRs?

[mlangsdorf]

Blazemod and aftershock both have vehicle parts with extremely high volume; please check that there aren't any problems with a mostly loaded "cargo dimension" (id: space_anomaly) from blazemod.

[kevingranade]

Sanity checks not being 100% effective is no reason to remove them entirely, the existing number is an utterly insane large number. Put another way, what's the use case for having more than 4,000 items in a single square?

…

On Sat, Nov 9, 2019, 6:02 AM Mark Langsdorf ***@***.***> wrote: Blazemod and aftershock both have vehicle parts with extremely high volume; please check that there aren't any problems with a mostly loaded "cargo dimension" (id: space_anomaly) from blazemod. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#35411?email_source=notifications&email_token=AAGSA5B3RVDTYGQN3WSTQLDQS27IFA5CNFSM4JK7SIKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUG3VQ#issuecomment-552103382>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSA5CFDIXADK2UOWFAJGDQS27IFANCNFSM4JK7SIKA> .

[kevingranade]

Also I've been considering having crafting enumeration NOT consider the entire huge pile of items, instead only searching the "uppermost" X volume worth of items.

[BevapDin]

Sanity checks not being 100% effective is no reason to remove them
entirely, the existing number is an utterly insane large number.

That is not a sanity check. That is an arbitrary limit. If we allow 4096 item on a square, why not 4097?

Put another way, what's the use case for having more than 4,000 items in a
single square?

#35398

I have encountered this problem on my own a few times.

---

And I have another argument: it's not realistic.

And the limit is actually not an item limit, but an item stack limit. One can put 10000 arrows (one stack, counts as 1) and 4095 other items on a square. But one can not put 10000 rocks (count as 10000) on a square.

[BevapDin]

Checked by dropping about 40,000 lighters on a trunk. 11607 of them got into the trunk and 28393 landed on the grass below. Examining the tiles (cargo/terrain) works fine, as does picking them up.

[kevingranade]

That is not a sanity check. That is an arbitrary limit.

That is not a contradiction, we don't know what number is going to cause an actual problem, so we limit it to an arbitrary number we think is safe. If you think that number is sometimes unsafe we can look into dropping it, if you think a higher number is necessary and will always be safe, we can look into raising it, but no limit is simply asking for trouble. The problem is, 4K is already a ridiculously high number that there is no sane rationale for reaching.

I'm not sure why you mention #35398, it doesn't have a rationale, just a bug report. The limit is involved in the bug, but if people are in the habit of trying to store everything in their base in a single tile, they will hit whatever limit exists, and I'd rather they hit a synthetic limit that we know the parameters of instead of him going off and discovering entirely new limits scattered all over the code base.
This includes future issues and performance issues.

[Maddremor]

It could be worthwhile to look for candidates for making item stacks instead of individual items. Rocks and rags stand out as reasonable off the top of my head.

[DMFan79]

That is not a sanity check. That is an arbitrary limit.

That is not a contradiction, we don't know what number is going to cause an actual problem, so we limit it to an arbitrary number we think is safe. If you think that number is sometimes unsafe we can look into dropping it, if you think a higher number is necessary and will always be safe, we can look into raising it, but no limit is simply asking for trouble. The problem is, 4K is already a ridiculously high number that there is no sane rationale for reaching.

I'm not sure why you mention #35398, it doesn't have a rationale, just a bug report. The limit is involved in the bug, but if people are in the habit of trying to store everything in their base in a single tile, they will hit whatever limit exists, and I'd rather they hit a synthetic limit that we know the parameters of instead of him going off and discovering entirely new limits scattered all over the code base.
This includes future issues and performance issues.

I've opened the thread (#35398) to suggest changing several items into stacks, I'm ok with having a limit per tile. The main problem is that after a while, even without hoarding like I do, the base storage gets messy. Stacks help alleviate the problem.

I'd like to hear what people think about my suggestion.

[ZhilkinSerg]

Let's postpone this post 0.E stable.

[kevingranade]

I'm fine with a different limit, but no limit is not an option.