Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftershock PrepNet Phyle Faction, mobs, locations #35322

Merged
merged 43 commits into from
Nov 22, 2019

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Nov 5, 2019

Summary

SUMMARY: Mods " Adding a bionic prepper faction to Aftershock"

Purpose of change

Creating a core faction for Aftershock will push it further into it's sci-fi setting and begin to set the tone for what types of additional content belongs in the mod.

Describe the solution

Created a faction, 2 monsters, 2 maps, one class and one NPC so far.

Describe alternatives you've considered

Doing less difficult things with my life.

Testing

Adding new monsters is the devil. Literally I may be starting to believe I am a sinner in the hands of an angry god.

Additional context

None

@KorGgenT KorGgenT added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON labels Nov 5, 2019
@Maleclypse
Copy link
Member Author

Maleclypse commented Nov 5, 2019

@LovamKicsiGazsii I'm getting a load stopping error saying that my npc class is unknown `` DEBUG : Error: line 64:33: unknown npc class

    { "monster": "GROUP_PrepNet", "x": [ 3, 20 ], "y": [ 16, 20 ], "repeat": 4 }
  ],
  "place_npcs": [ { "class":
                            ^
                             "afs_prepnet_gardener", "x": 10, "y": 9 } ]
}

FUNCTION : bool main_menu::new_character_tab()
FILE : src/main_menu.cpp
LINE : 741``

I thought you might have an idea where I've gone awry based on your work on the Church faction. :)

edit: Looked through your PR some more and solved that problem. Now on to all the non gamebreaking problems.

@ghost
Copy link

ghost commented Nov 13, 2019

Atomic churner?
Fascinating :O

Still need to add Churn tool quality from dairy products WIP and figure out what's wrong with the quest. Progress!
Still need improved dialogue tree.   Remember to delete churn from AFS once Dairy products mainline.
@Maleclypse
Copy link
Member Author

Atomic churner?
Fascinating :O

Hi-tech pioneer living. :)

Trying to make cyber mastiffs attack when PrepNet NPC is attacked.
@Maleclypse
Copy link
Member Author

Maleclypse commented Nov 15, 2019

Doing some testing. I've listed the cybermastiffs as part of a Mon_faction that is friendly with the NPC faction. If I attack the NPC the mob doesn't attack me. If I attack the mob the NPC rushes to my rescue and kills the mob he's supposed to be friendly with. Any suggestions? I had thought that mirroring Apis_Hive would work, but I'm not actually sure the bees and Apis are friendly with each other now that I'm looking at it again.

Copy link
Contributor

@mlangsdorf mlangsdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dialogue "topic" references are case sensitive.

data/mods/Aftershock/npcs/afs_prepnet_dialogue.json Outdated Show resolved Hide resolved
data/mods/Aftershock/npcs/afs_prepnet_dialogue.json Outdated Show resolved Hide resolved
data/mods/Aftershock/npcs/afs_prepnet_dialogue.json Outdated Show resolved Hide resolved
data/mods/Aftershock/npcs/afs_prepnet_dialogue.json Outdated Show resolved Hide resolved
data/mods/Aftershock/npcs/afs_prepnet_dialogue.json Outdated Show resolved Hide resolved
@mlangsdorf
Copy link
Contributor

diff --git a/data/mods/Aftershock/npcs/afs_prepnet_dialogue.json b/data/mods/Aftershock/npcs/afs_prepnet_dialogue.json
index e7de38c681..6b98f13b78 100644
--- a/data/mods/Aftershock/npcs/afs_prepnet_dialogue.json
+++ b/data/mods/Aftershock/npcs/afs_prepnet_dialogue.json
@@ -19,103 +19,103 @@
         "text": "Who are you?",
         "effect": { "u_add_var": "u_met_prepnet_gardener", "type": "general", "context": "meeting", "value": "yes" },
         "condition": { "not": { "u_has_var": "u_met_prepnet_gardener", "type": "general", "context": "meeting", "value": "yes" } },
-        "topic": "TALK_prepnet_gardener_firstmeet"
+        "topic": "TALK_PrepNet_gardener_firstmeet"
       },
       {
         "text": "What is this place?",
         "condition": { "u_has_var": "u_met_prepnet_gardener", "type": "general", "context": "meeting", "value": "yes" },
-        "topic": "TALK_prepnet_gardener_place"
+        "topic": "TALK_PrepNet_gardener_place"
       },
       {
         "text": "What's your story?",
         "condition": { "u_has_var": "u_met_prepnet_gardener", "type": "general", "context": "meeting", "value": "yes" },
-        "topic": "TALK_prepnet_gardener_ask_past"
+        "topic": "TALK_PrepNet_gardener_ask_past"
       },
       {
         "text": "How are things here?",
         "condition": { "u_has_var": "u_met_prepnet_gardener", "type": "general", "context": "meeting", "value": "yes" },
-        "topic": "TALK_prepnet_gardener_ask_mood"
+        "topic": "TALK_PrepNet_gardener_ask_mood"
       },
       {
         "text": "Can I do anything for you?",
         "condition": { "u_has_var": "u_met_prepnet_gardener", "type": "general", "context": "meeting", "value": "yes" },
         "topic": "TALK_MISSION_LIST"
       },
-      { "text": "How do I join the phyle?", "topic": "TALK_prepnet_gardener_ask_membership" }
+      { "text": "How do I join the phyle?", "topic": "TALK_PrepNet_gardener_ask_membership" }
     ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_firstmeet",
+    "id": "TALK_PrepNet_gardener_firstmeet",
     "dynamic_line": "I'm a gardener for PrepNet Phyle.  Who are you?",
     "responses": [
-      { "text": "I am a beggar who really needs something to eat.", "topic": "TALK_prepnet_gardener_ask_food" },
-      { "text": "I am just a fellow survivor.", "topic": "TALK_prepnet_gardener_1" },
+      { "text": "I am a beggar who really needs something to eat.", "topic": "TALK_PrepNet_gardener_ask_food" },
+      { "text": "I am just a fellow survivor.", "topic": "TALK_PrepNet_gardener_1" },
       { "text": "I'm bringing order back to the land.", "topic": "TALK_PrepNet_gardener_1" }
     ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_place",
+    "id": "TALK_PrepNet_gardener_place",
     "dynamic_line": "This is a PrepNet Phyle orchard. We were a community of survivalists gathering resources to prepare for climate change, but it left us better prepared for what actually happened than most.",
     "responses": [
-      { "text": "Can you give me something to eat then?", "topic": "TALK_prepnet_gardener_ask_food" },
-      { "text": "What can I buy here?", "topic": "TALK_prepnet_gardener_ask_goods" },
-      { "text": "Oh, okay.", "topic": "TALK_prepnet_gardener_1" }
+      { "text": "Can you give me something to eat then?", "topic": "TALK_PrepNet_gardener_ask_food" },
+      { "text": "What can I buy here?", "topic": "TALK_PrepNet_gardener_ask_goods" },
+      { "text": "Oh, okay.", "topic": "TALK_PrepNet_gardener_1" }
     ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_food",
+    "id": "TALK_PrepNet_gardener_ask_food",
     "dynamic_line": "This food has to go back to our core communities. But maybe we can trade some food for services",
     "responses": [
-      { "text": "I can pay.", "topic": "TALK_prepnet_gardener_ask_food_bribe" },
+      { "text": "I can pay.", "topic": "TALK_PrepNet_gardener_ask_food_bribe" },
       { "text": "What do you need done?", "topic": "TALK_MISSION_LIST" }
     ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_ask_food_bribe",
+    "id": "TALK_PrepNet_gardener_ask_food_bribe",
     "dynamic_line": "You have to earn the right to trade with us. Plus we created our own currency before the cataclysm",
     "responses": [
-      { "text": "It was worth a try.", "topic": "TALK_prepnet_gardener_1" },
-      { "text": "What kind of currency?", "topic": "TALK_prepnet_gardener_currency" }
+      { "text": "It was worth a try.", "topic": "TALK_PrepNet_gardener_1" },
+      { "text": "What kind of currency?", "topic": "TALK_PrepNet_gardener_currency" }
     ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_ask_membership",
+    "id": "TALK_PrepNet_gardener_ask_membership",
     "dynamic_line": "This is just an outpost, you'd have to find our main camp and currently we don't want you to.",
-    "responses": [ { "text": "I didn't want to join your club anyway.", "topic": "TALK_prepnet_gardener_1" } ]
+    "responses": [ { "text": "I didn't want to join your club anyway.", "topic": "TALK_PrepNet_gardener_1" } ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_ask_goods",
+    "id": "TALK_PrepNet_gardener_ask_goods",
     "dynamic_line": "Here? Fruits and berries. Maybe the occasional piece of farm equipment, but you need crypto coins",
     "responses": [
-      { "text": "Ok.", "topic": "TALK_prepnet_gardener_1" },
-      { "text": "What are crypto coins?", "topic": "TALK_prepnet_gardener_currency" }
+      { "text": "Ok.", "topic": "TALK_PrepNet_gardener_1" },
+      { "text": "What are crypto coins?", "topic": "TALK_PrepNet_gardener_currency" }
     ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_ask_past",
+    "id": "TALK_PrepNet_gardener_ask_past",
     "dynamic_line": "I got introduced to the movement through Mutual Aid Society. From there it became an all consuming part of my life to prepare for a post consumption world. It seems to have worked better for us than for many others.",
-    "responses": [ { "text": "Let's talk about something else.", "topic": "TALK_prepnet_gardener_1" } ]
+    "responses": [ { "text": "Let's talk about something else.", "topic": "TALK_PrepNet_gardener_1" } ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_ask_mood",
+    "id": "TALK_PrepNet_gardener_ask_mood",
     "dynamic_line": "It can get lonely out here between caravans.  But there's plenty of work and my Cyber Mastiffs.  If a horde comes through we hunker down in a nearby shelter if it's too large for us.",
-    "responses": [ { "text": "I'm glad you stay busy.", "topic": "TALK_prepnet_gardener_1" } ]
+    "responses": [ { "text": "I'm glad you stay busy.", "topic": "TALK_PrepNet_gardener_1" } ]
   },
   {
     "type": "talk_topic",
-    "id": "TALK_prepnet_gardener_currency",
+    "id": "TALK_PrepNet_gardener_currency",
     "dynamic_line": "We use crypto coins for money here. They were a pre cataclysm attempt to abstract money even further and create electronic cash. We figured we'd keep it up. Barter only gets you so far.",
     "responses": [
-      { "text": "Oh, okay.", "topic": "TALK_prepnet_gardener_1" },
-      { "text": "What can I buy here?", "topic": "TALK_prepnet_gardener_ask_goods" }
+      { "text": "Oh, okay.", "topic": "TALK_PrepNet_gardener_1" },
+      { "text": "What can I buy here?", "topic": "TALK_PrepNet_gardener_ask_goods" }
     ]
   },
   {

These are all the changes that need to be made to make all the topics start with "TALK_PrepNet_gardener" and for all the topics to be correctly referenced.

@Maleclypse
Copy link
Member Author

Faction Fail

I'm trying to make the cyber-mastiff's treat PrepNet_Phyle faction NPCs the same way that Giant Bees treat Apis. Currently the mastiff's remain neutral until they see zombies. It appears that once zombies appear they attack everyone including the faction NPCs they are supposed to be aligned with. I'm not having luck determining how Apis stays neutral to bees in similar situations.

@Maleclypse Maleclypse changed the title WIP Aftershock PrepNet Phyle Faction, mobs, locations Aftershock PrepNet Phyle Faction, mobs, locations Nov 19, 2019
@ZhilkinSerg ZhilkinSerg merged commit 3fd65f1 into CleverRaven:master Nov 22, 2019
@John-Candlebury John-Candlebury added the Mods: Aftershock Anything to do with the Aftershock mod label Jan 8, 2020
@Amariithynar
Copy link

The Tripods are unceasingly hostile to me just for coming near to them when they're attacking a Fungal Tower; they stopped prioritizing attacking the Mycus and turned on me. If it wasn't night time, I'd have been mobbed by like 15 of them; as soon as I got away, they completely tore through every fungal creature and structure there, and then started hunting for me. I'm neutral with PrepNet; they should probably not be aggro to me when I'm not infected or Mycus myself.

@Maleclypse
Copy link
Member Author

The Tripods are unceasingly hostile to me just for coming near to them when they're attacking a Fungal Tower; they stopped prioritizing attacking the Mycus and turned on me. If it wasn't night time, I'd have been mobbed by like 15 of them; as soon as I got away, they completely tore through every fungal creature and structure there, and then started hunting for me. I'm neutral with PrepNet; they should probably not be aggro to me when I'm not infected or Mycus myself.

That should be fixed in the upcoming experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants