Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe fuel Mode #35205

Merged
merged 13 commits into from
Nov 18, 2019
Merged

Safe fuel Mode #35205

merged 13 commits into from
Nov 18, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Oct 31, 2019

Summary

SUMMARY: Features "Introduces safe fuel mod and flags for bionics"

Purpose of change

Having your fueled CBM turning off to save fuel is now an option called fuel saving mode and it's on by default.

Describe the solution

Implement flags for bionic
Use flag to tell if a bionic has it's fuel saving mode on or not
Update bionic menu to allow toggling fuel saving mode

Describe alternatives you've considered

Testing

Start bionic gangster game
Turn on MI CBM
It does not turn off
Toggle safe fuel mode
MI turns off when you reach max power

Additional context

image

@Brytenwalda
Copy link
Contributor

I think what you meant was “save fuel mod”, not safe.

@kevingranade
Copy link
Member

I don't see any reason that this shouldn't be the default behavior.

@Amoebka
Copy link
Contributor

Amoebka commented Nov 1, 2019

Shouldn't it be "fuel saving mode"?

src/bionics_ui.cpp Outdated Show resolved Hide resolved
@Fris0uman Fris0uman changed the title Safe fuel Mod Safe fuel Mode Nov 1, 2019
src/bionics.cpp Outdated Show resolved Hide resolved
src/bionics_ui.cpp Outdated Show resolved Hide resolved
src/bionics_ui.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) Info / User Interface Game - player communication, menus, etc. labels Nov 18, 2019
@ZhilkinSerg ZhilkinSerg merged commit d83ada4 into CleverRaven:master Nov 18, 2019
@Fris0uman Fris0uman deleted the safe_fuel branch November 18, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants