jsonizes zones into item_category #35176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[JSON]
Qrox
reviewed
Oct 31, 2019
KorGgenT
force-pushed
the
item-category-zone
branch
from
cda5d55 to
a966e8d
Compare
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* add zones to item categories * move zones from hardcode to JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Moves zone types into JSON for item category"Purpose of change
This is on the way to completing #26380
Allowing item categories to have their sort zones be defined via JSON.
Describe the solution
adds a member to item_category that is a zone_type_id, and gets that in zone_manager::get_near_zone_type_for_item()
Testing
created a zone, the spawned some items and autosorted into that zone. the items properly got sorted.
Additional context
relies on #35147 as a prerequisite