reimplement item_category loading via generic_factory #35147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
KorGgenT
force-pushed
the
item_category-generic_factory
branch
2 times, most recently
from
21ca0bc to
bbbd9ac
Compare
KorGgenT
force-pushed
the
item_category-generic_factory
branch
from
bbbd9ac to
28265d4
Compare
|
Tests are failing to compile. |
|
will have to look at that later tonight - maybe by 9 hours from now |
reimplement loading from Item_factory to use generic_factory
KorGgenT
force-pushed
the
item_category-generic_factory
branch
from
0b41857 to
0ec0504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "reimplement item_category loading via generic_factory"Purpose of change
In order to make it easier to approach a fix for #26380
Describe the solution
Pulls out Item_factory's handling of loading item_category in json and uses generic_factory.
Testing
Compiled, loaded up a game, and checked some items for categories. categories seemed to be assigned properly and no errors popped up.