Infrastructure for using vitamin system for toxins #34695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davi-DeGanne
changed the title
Davi-DeGanne
changed the title
KorGgenT
added
[C++]
|
Would this be able to be used for intolerances like gluten and lactose? |
Yes, definitely. |
Davi-DeGanne
force-pushed
the
vitamin-optional-deficiency
branch
from
6e150bb to
16de776
Compare
added 4 commits
October 18, 2019 07:13
To make it possible to use the vitamin infrastructure for toxin buildup. Required infrastructure for re-PR of 34636.
Davi-DeGanne
force-pushed
the
vitamin-optional-deficiency
branch
from
16de776 to
4f8e68c
Compare
|
Making this a WIP until I can test it more, keep running into bugs in the vitamin code. |
Davi-DeGanne
changed the title
added 2 commits
October 20, 2019 05:05
Previously, starve_test_hunger3 was way too strict to ever pass, and the diet it was supplying was deficient in several vitamins. However, it was going unnoticed because the buffer-not-being-cleared bug meant that by the end of the 20 days, the test player was getting ~2000% vitamins/day.
Davi-DeGanne
changed the title
|
Removing the [WIP] tag, I have tested this pretty thoroughly using #34878 and it is working as intended. |
va5h
pushed a commit
to va5h/Cataclysm-DDA
that referenced
this pull request
Oct 23, 2019
* Make vitamin 'deficiency' field optional To make it possible to use the vitamin infrastructure for toxin buildup. Required infrastructure for re-PR of 34636. * Implement severity above 1 for vitamin excess * Fix existing bug that capped stored vitamins at 0 * Clear vitamins_absorbed buffer after using it * Loosen up starve_test_hunger3 so it passes Previously, starve_test_hunger3 was way too strict to ever pass, and the diet it was supplying was deficient in several vitamins. However, it was going unnoticed because the buffer-not-being-cleared bug meant that by the end of the 20 days, the test player was getting ~2000% vitamins/day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add infrastructure to support using vitamin system for toxins"Purpose of change
The vitamin system would be perfectly set up for representing food-borne toxin buildup in the body with only a few small modifications.
Required for #34878
Describe the solution
max.