Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add items to steel mill #34347

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Add items to steel mill #34347

merged 3 commits into from
Sep 30, 2019

Conversation

snipercup
Copy link
Contributor

@snipercup snipercup commented Sep 30, 2019

Summary

SUMMARY: Content "Adds items to steel mill"

Purpose of change

helps #34307

Describe the solution

Adds items to the steel mill map special.

  • Undid my earlier PR Add items to office rooms in steel mill #34335, it was not an effective method for adding items. I used the palette instead.

  • Changed the letters of some furniture to get the right items on them. Counters in the office should have different items then counters in the mill. I did not change any furniture, the steel mill is the same as it was except now there are items.

  • Found some useful item groups and added 2 of my own to get as close to the idea of the steel mill author as possible (Adds steel mill location #33383). As far as I can tell there are no iron ores and steel ingots so I just added what I thought was relevant.

  • It still needs monsters but that will be in another PR (not necessarily by me).

Describe alternatives you've considered

Leaving as is

Additional context

With increased item spawn for demonstration:

image

image

image

image

image

image

Actual spawn chances:

image

image

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map labels Sep 30, 2019
@ZhilkinSerg ZhilkinSerg merged commit 4de2067 into CleverRaven:master Sep 30, 2019
@snipercup snipercup deleted the Add-steel-mill-items branch September 30, 2019 18:01
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/i-found-a-steel-mill-severely-dissapointed/21557/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants