Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add items to office rooms in steel mill #34335

Merged
merged 3 commits into from
Sep 29, 2019
Merged

Add items to office rooms in steel mill #34335

merged 3 commits into from
Sep 29, 2019

Conversation

snipercup
Copy link
Contributor

Summary

SUMMARY: Content "Adds items to steel mill office area"

Purpose of change

Helps #34307

Describe the solution

Added item spawns to the office rooms in the steel mill. Office items on the desks, snacks on the one table, homebooks in the bookcases.

Describe alternatives you've considered

Use items[] pallette style instead, but maybe you'd want to add different items on the tables in the other area's in the steel mill instead of the same item group for all the tables.

Additional context

image
The item spawns were set to a higher spawn scale for demonstration.

@anothersimulacrum
Copy link
Member

I'd suggest you have item spawns at a fairly high rate - offices would have a fair bit of stuff, and nobody would have taken them.

@snipercup
Copy link
Contributor Author

I'd suggest you have item spawns at a fairly high rate - offices would have a fair bit of stuff, and nobody would have taken them.

Yeah it did cross my mind but you're right. who'd empty a steel mill office during a cataclysm? Changed to 70 because I saw that number in another mapgen file (teashop?)

@anothersimulacrum
Copy link
Member

anothersimulacrum commented Sep 29, 2019

You may also want to add "repeat": [ 'some_number', 'other_number' ]

@snipercup
Copy link
Contributor Author

You may also want to add "repeat": [ 'some_number', 'other_number' ]

I think one chance of 70% for each tile is fair enough.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map labels Sep 29, 2019
@ZhilkinSerg ZhilkinSerg merged commit d47f930 into CleverRaven:master Sep 29, 2019
@snipercup snipercup deleted the Add-item-spawns-to-steel-mill-office-rooms branch September 29, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants