Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of bounds access in cata_tiles::draw #34216

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Sep 24, 2019

Summary

SUMMARY: None

Purpose of change

Fix out of bound access in cata_tiles::draw. Should fix #34201. @moxian please check if this fixes your crash, as I can't reproduce it on my machine.

Describe the solution

Use fallback light level values for tiles outside visible range but still drawn (memory or overrides).

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels Sep 24, 2019
@moxian
Copy link
Contributor

moxian commented Sep 24, 2019

Patching in this PR fixes my crash in #34201, yes. Thanks!

@kevingranade kevingranade merged commit 15709fa into CleverRaven:master Sep 25, 2019
@Qrox Qrox deleted the fix-catatiles-draw branch September 27, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when looking around (x)
4 participants