Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Leadworks weapons from professions, military itemgroups #31736

Merged
merged 4 commits into from
Jun 23, 2019

Conversation

ymber
Copy link
Member

@ymber ymber commented Jun 22, 2019

Summary

SUMMARY: Bugfixes "Remove fictional guns from profession items and military itemgroups"

Purpose of change

Fixes #31577
Leadworks weapons are inappropriate for military item groups.

Describe the solution

Move leadworks guns from military itemgroups to rare gun itemgroups. Replace fictional guns in professions with appropriate alternatives.

Additional context

While doing this I noticed that we have no nonfictional milspec shotguns. This should be rectified elsewhere. I didn't touch Rivtech weapons in this but we may want to consider moving them to other itemgroups too.

@ZhilkinSerg ZhilkinSerg self-assigned this Jun 23, 2019
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map labels Jun 23, 2019
@ZhilkinSerg ZhilkinSerg merged commit d623d97 into CleverRaven:master Jun 23, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jun 23, 2019
@ymber ymber deleted the lw_itemgroups branch June 23, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bionic Soldier Profession with No Fictional Weapons Mod results in having no Rifle
2 participants