Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bionic Soldier Profession with No Fictional Weapons Mod results in having no Rifle #31577

Closed
RedPine91 opened this issue Jun 17, 2019 · 6 comments · Fixed by #31736
Closed

Bionic Soldier Profession with No Fictional Weapons Mod results in having no Rifle #31577

RedPine91 opened this issue Jun 17, 2019 · 6 comments · Fixed by #31736
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies

Comments

@RedPine91
Copy link

Describe the bug

"No Fictional Weapons" mod removes the rifle that the "Bionic Soldier" profession starts with, causing the "Bionic Soldier" to start with no rifle at all.

Expected behavior

Item removal mods replace removed items with similar allowed items, or at least warn the player that a mod has removed part of a profession's starting gear.

@RedPine91 RedPine91 changed the title Bionic Soldier Profession with No Fictional Weapons Mod results in having no Rifle [P Bionic Soldier Profession with No Fictional Weapons Mod results in having no Rifle [Character Generation] Jun 17, 2019
@RedPine91 RedPine91 changed the title Bionic Soldier Profession with No Fictional Weapons Mod results in having no Rifle [Character Generation] Bionic Soldier Profession with No Fictional Weapons Mod results in having no Rifle Jun 17, 2019
@Night-Pryanik
Copy link
Contributor

Night-Pryanik commented Jun 18, 2019

Item removal mods are doing what are they expected to do - remove items. They ain't supposed to provide alternatives or replacements for weapons they remove.

We can't and won't guarantee compatibility with every mod created (even the ones in "official" bundle with the game), so it's player responsibility when he activates a mod.

@Night-Pryanik Night-Pryanik added Items / Item Actions / Item Qualities Items and how they work and interact Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Jun 18, 2019
@kevingranade
Copy link
Member

We might be able to check for dependencies and remove a profession that has missing gear.

@eilaattwood
Copy link
Contributor

I find it strange to discard fictional guns but to take fictional profession for the character that is intended to use fictional gun and abilities. So I agree with Kevin, professions that use blacklisted gear should be blacklisted too.

@Hatfish
Copy link

Hatfish commented Jun 20, 2019

Would that mesh well with something like the generic guns mod?

@kevingranade
Copy link
Member

Yes, it would blacklist every profession that starts with a gun.

@kevingranade
Copy link
Member

When you load your world, do you get the error
profession Bionic Soldier: item rm51_assault_rifle does not exist"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants