Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNG function: one turn in time duration #31629

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Jun 19, 2019

Summary

SUMMARY: Infrastructure "one_turn_in(time_duration) function added"

Purpose of change

Implement #31430 (comment).

Would it be cleaner to have a one_turn_in function that's like one_in but takes a time argument?

Describe the solution

Added one_turn_in(time_duration) function.
Used one_turn_in(time_duration) function in player.cpp where one_in( to_turns<int>( time_duration ) ) were.

Describe alternatives you've considered

Leave as is.

@ifreund ifreund added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Time / Turns / Duration / Date Issues concerning any activities being too fast or too slow. Also issues about time and date ingame labels Jun 19, 2019
@ZhilkinSerg ZhilkinSerg merged commit e0e5784 into CleverRaven:master Jun 19, 2019
@AMurkin AMurkin deleted the one-in-time-duration branch June 19, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Time / Turns / Duration / Date Issues concerning any activities being too fast or too slow. Also issues about time and date ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants