Removing long (part 4): Remove support for serializing longs #31483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
Longs are of different size on Windows and Linux, which means serializing longs leads to non-portable savegames or game data. Also, the serializing of longs was via doubles, which means we couldn't support longs with full precision anyway. All the things that were serialized as longs are now done as ints: - Charges of various sorts. - Cash amounts for the player and mission rewards. - Map symbols (which are usually unicode codepoints, or a handful of other special values).
jbytheway
force-pushed
the
no_longs_in_json
branch
from
474a93a to
988b18e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
longs are of different size on Windows and Linux, which means serializinglongs leads to non-portable savegames or game data.Also, the serializing of
longs was viadoubles, which means we couldn't supportlongs with full precision anyway.Describe the solution
All the things that were serialized as
longs are now done asints:Some changes for charges values becoming
intare in this PR rather than #31453 because they were passed by reference to these long function.Describe alternatives you've considered
I considered adding serialization of
int64_t, but decided YAGNI.Additional context
Part of my ongoing effort to remove all
longs from the code.