Removing long (part 2): Convert item charges to int #31453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual charges value in the item objects was changed to an int a while ago, but many other places working with charges or amounts of items were still using long. Convert those.
ZhilkinSerg
added
[C++]
|
shakes fist I was just about to merge that! |
Nelson: HA-HA! |
This was referenced Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Continuing effort to eliminate uses of
long.The actual
chargesvalue in theitemobjects was changed to aninta while ago, but many other places working with charges or amounts of items were still using long.Describe the solution
Convert those.