Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new pneumatic shotgun #31294

Merged
merged 16 commits into from
Jun 11, 2019
Merged

Adds a new pneumatic shotgun #31294

merged 16 commits into from
Jun 11, 2019

Conversation

ddsaw
Copy link
Contributor

@ddsaw ddsaw commented Jun 10, 2019

SUMMARY

SUMMARY: Content "Adds a new double barrel pneumatic shotgun"

Purpose of change

Currently there is no good shotgun to use for training, and no "low power silent, available ammo" option, either. Since shotgun silencers are very rare, I felt like a pneumatic shotgun like this could do the trick.

Describe the solution

The implemented gun is quite a bit weaker compared to a standard double barreled shotgun, both in reload time and damage. Ammo comes in a few varieties with the best consuming 10 flechettes per craft and the worst simple taking pebbles and scrap off the ground.
Currently there is no crafting recipe for the gun itself because I didn't find the recipe for the other pneumatics guns in the recipes: ranged json, but it will be equivalent to what the other pneumatics take.

Describe alternatives you've considered

I've considered making it single barrel aswell as reducing it's damage but after some testing comparing it against the blunderbuss and double barreled I believe I should get some other opinions first, considering how controversial pneumatics apparently are.
I would consider adding a recipe book like "Tactical Airgun Digest" or something as a crafting requirement to all pneumatics, but that would better be handled in a separate issue (also I would have to find these item recipes first).

Adds a new pneumatic shotgun alongside it's ammotypes. It's quite a bit weaker than a conventional double barrel but quiet by default. Has no crafting recipe yet, WIP
@ghost
Copy link

ghost commented Jun 10, 2019

Do you have a real-life version to compare this gun & ammo to? The very cheap ammo recipes seems way off on realism.

(I really want this since every other ranged weapon skill has a cheap way to train them, including launchers via spraycan flamethrower, but I don't want it to be "just because I want it" 😛 )

@ddsaw
Copy link
Contributor Author

ddsaw commented Jun 10, 2019

Do you have a real-life version to compare this gun & ammo to?

(I really want this since every other ranged weapon skill has a cheap way to train them, including launchers via spraycan flamethrower, but I don't want it to be "just because I want it" )

I'm thinking about the many subsistence hunting airshotguns that are used in countries where conventional shotguns are banned. Examples are the Falco Arms Air shotguns aswell as the korean Yewha shotguns. As for being double barreled look into the Seneca Doubleshot.
The Yewha specifically is a handpumped, hand crafted(or so I think), cheap airshotgun albeit single barrel, though a double barreled design wouldn't be unfeasible to make.
The ammo is inspired by those same guns(they're functionally shotgunshells without powder), but I will gladly change it to require plastic molds or whatever aswell as a few plastic chunks for the hull if you think a paper shell wouldn't be enough.

ddsaw and others added 2 commits June 10, 2019 06:54
Co-Authored-By: Anton Burmistrov <[email protected]>
@Night-Pryanik
Copy link
Contributor

Please run your changes through the json linter.

@ddsaw
Copy link
Contributor Author

ddsaw commented Jun 10, 2019

Please run your changes through the json linter.

Yeah sorry, I didn't really understand how to use it or what it does, but I think I get it now. It basically removes stupid formatting errors right? Do I just have to copypaste literally every file I touch and run it through there and then paste it back in?

@Night-Pryanik
Copy link
Contributor

It basically removes stupid formatting errors right?

Well, yeah.

Do I just have to copypaste literally every file I touch and run it through there and then paste it back in?

Well, yeah.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 216fe4b into CleverRaven:master Jun 11, 2019
@Rivet-the-Zombie
Copy link
Member

Rivet-the-Zombie commented Jun 11, 2019

The ammo could really use a carrier, perhaps the extant paper cartridge pouch or shotgun bandoliers?

@ddsaw
Copy link
Contributor Author

ddsaw commented Jun 11, 2019

The ammo could really use a carrier, perhaps the extant paper cartridge pouch or shotgun bandoliers?

I didn't understand how to add a second ammotype to the bandolier, and my attempts at doing so failed. I considered adding it's own bandolier and infact I got that working, but in my head I couldn't justifiy not using the extant versions.

@ghost ghost mentioned this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants