Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm: update mana regen less often #31293

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

KorGgenT
Copy link
Member

@KorGgenT KorGgenT commented Jun 10, 2019

this allows for larger chunks of mana to be regenerated at a time

Summary

SUMMARY: Bugfixes "make mana regen less often in larger chunks"

Purpose of change

Fixes #31271

Describe the solution

With the time change, 10 turns became a lot shorter, so the calculations cause mana regen to be 0 more often than not with mana regen. I increase it from 10 turns to 3 minutes, so with very bad mana regen you're likely to have at least 1 regen every 3 minutes.

this allows for larger chunks of mana to be regenerated at a time
@KorGgenT KorGgenT added Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Character / Player Character / Player mechanics labels Jun 10, 2019
@ZhilkinSerg ZhilkinSerg merged commit 49253fc into CleverRaven:master Jun 10, 2019
@jbytheway
Copy link
Contributor

If this is because of rounding, have you considered using roll_remainder?

@KorGgenT KorGgenT added the Mods: Magiclysm Anything to do with the Magiclysm mod label Jun 30, 2019
@KorGgenT KorGgenT deleted the mana-regen-fix branch August 13, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magiclysm mana does not regenerate
3 participants