Zinc WIP do not merge #31217
Closed
Zinc WIP do not merge #31217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you heard the good word about draft pull requests, friend? |
ZhilkinSerg
added
[JSON]
Merged
|
This was merged as of #31031, right? |
Yeah, can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "adds the material zinc and changes several items' material to zinc"
Purpose of change
Purpose of change: There is no zinc material in the game as of now, and adding it doesn't seem like it can make the game any worse.
Describe the solution
Describe the solution: adds the material zinc in the, and then changes some batteries, a gun, flatcoins, and maybe more to zinc.
Describe alternatives you've considered
Describe alternatives you've considered: We could not add it as a material, for it doesn't apply to many items.
Additional context
Additional context: I'm not gonna pretend that I know much about this. I have no idea what the numbers for zinc should be (like the bash and cut resistance) so if anyone has any ideas on that I'd implement them in a heart beat. What I'm saying is if there's an item which should be zinc, or the zinc numbers should be something else, please tell me.