RPG dice #31031

krekeler0 · 2019-06-01T04:59:15Z

Summary

Summary: Content "adds rpg dice and makes the game master profession start with them"

Purpose of change

Purpose of Change: Now as I didn't fix a bug I don't know if I should use this, but just in case I am I'll do it anyways. I saw that the game master didn't have any dice, and most rpgs use dice. I figured I'd just add them in and see if anyone saw any reason for them existing.

Describe the solution

Describe the Solution: The dice are (unless I messed up) usable as ammunition for the sling and slingshot. They are pretty much marbles with slightly adjusted stats such as less damage and higher range.

Describe alternatives you've considered

Describe alternatives you've considered: I mean I haven't considered any alternatives besides just not having the dice put in. They don't really contribute much to the game after all.

Additional context

The zinc material is also added in #31217 If one is merged the other one will have its zinc material removed.

anothersimulacrum · 2019-06-01T05:02:14Z

data/json/items/ammo.json

+    "type": "AMMO",
+    "id": "rpg_dice",
+    "price": 10,
+    "name": "rpg dice",


You need a "name_plural", or else multiples will show up as x rpg dices.
(The plural name should be the same, because it's already plural)

okay so (I really don't know how this works) should I end this one and make a new one with that in?

No, you make the change, commit it, and push it to this branch.

also, the singular is "die"

Rivet-the-Zombie · 2019-06-01T05:19:08Z

These ought to spawn somewhere in-world too, not just in the DM's starting gear.

YukariMindGap · 2019-06-01T05:55:03Z

Don't forget the rpg table basement room!

I-am-Erk · 2019-06-01T06:07:54Z

One step closer to me programming an entire session of d&d in the game with NPCs

ghost · 2019-06-01T07:48:02Z

You can get metal rpg dice. These could have higher damage and range.

Example of metal dice

Leland · 2019-06-01T15:06:56Z

data/json/items/ammo.json

+    "id": "rpg_dice",
+    "price": 10,
+    "name": "rpg dice",
+    "name_plural": "rpg dice",


Here and above, "RPG" should be all caps

Leland · 2019-06-01T15:09:32Z

data/json/items/ammo.json

+    "symbol": "=",
+    "color": "light_gray",
+    "looks_like": "marble",
+    "description": "Some dice used to play various role playing games, coming in several shapes and sizes",


The description should be for that of a singular die (rather than "some dice"). Also, "role-playing" is hyphenated

Eg

Suggested change

"description": "Some dice used to play various role playing games, coming in several shapes and sizes",

"description": "A die often used to play various role-playing games",

There's no reason the item can't depict a set of dice. A deck of cards is a single item, not 52 individual playing cards.

Per the PR:

The dice are (unless I messed up) usable as ammunition for the sling and slingshot. They are pretty much marbles with slightly adjusted stats such as less damage and higher range.

It probably makes more sense to be shooting individual die, no?

anothersimulacrum · 2019-06-01T17:12:39Z

You need to lint your changes (paste the whole file you editing into the linter, format it, and paste it back into the file).

anothersimulacrum · 2019-06-01T19:40:04Z

data/json/professions.json

@@ -3582,7 +3582,7 @@
    "skills": [ { "level": 2, "name": "speech" }, { "level": 1, "name": "survival" } ],
    "items": {
      "both": {
-        "items": [ "jeans", "tshirt", "socks", "sneakers", "mbag", "pizza_cheese", "cola", "dnd_handbook", "wristwatch" ],
+        "items": [ "jeans", "tshirt", "socks", "sneakers", "mbag", "pizza_cheese", "cola", "dnd_handbook", "wristwatch", "rpg_dice" ],


Suggested change

"items": [ "jeans", "tshirt", "socks", "sneakers", "mbag", "pizza_cheese", "cola", "dnd_handbook", "wristwatch", "rpg_dice" ],

"items": [ "jeans", "tshirt", "socks", "sneakers", "mbag", "pizza_cheese", "cola", "dnd_handbook", "wristwatch", "RPG_dice" ],

thank you when changing the ID I forgot about that.

egorzaderiy · 2019-06-05T05:54:08Z

This would be even better if dice can be activated to roll it and get number, like already existing coin

Add die use action

anothersimulacrum · 2019-06-06T22:33:39Z

This would be even better if dice can be activated to roll it and get number, like already existing coin

Done! If anyone has comments/reviews on the C++ changes, I'm the person responsible for that.

(wire is replaced with the item's name, this is just an image from testing)

AMurkin · 2019-06-07T06:00:54Z

src/item.cpp

@@ -2691,6 +2691,11 @@ std::string item::info( std::vector<iteminfo> &info, const iteminfo_query *parts
                }
            }
        }
+        if( this->get_var( "die_num_sides", 0 ) != 0 ) {
+            info.emplace_back( "DESCRIPTION",
+                               string_format( _( "* This item can be used as a <info>die</info>, and has %s sides." ),


Add accent maybe?

Suggested change

string_format( _( "* This item can be used as a <info>die</info>, and has %s sides." ),

string_format( _( "* This item can be used as a <info>die</info>, and has <info>%s</info> sides." ),

Night-Pryanik · 2019-06-07T06:11:41Z

src/iuse.cpp

@@ -4051,6 +4051,23 @@ int iuse::mp3_on( player *p, item *it, bool t, const tripoint &pos )
    return it->type->charges_to_use();
 }

+int iuse::rpgdie( player *you, item *die, bool, const tripoint & )
+{
+    const std::array<int, 6> sides_options = { 4, 6, 8, 10, 12, 20 };


Hey, I need this one too

:-)

Adjust use action a bit

src/item.cpp

Co-Authored-By: anothersimulacrum <[email protected]>

anothersimulacrum · 2019-06-10T01:36:17Z

data/json/items/ammo.json

+    "color": "light_gray",
+    "looks_like": "marble",
+    "description": "A metal die used to play various role-playing games",
+    "material": "zinc",


This material does not exist

Right, I made another PR adding it, and removed it from this one. I'll put it back in this one and just mention that in both PRs.

adamkad1 · 2019-06-12T02:03:43Z

add d4 that can be used as caltrops

krekeler0 added 2 commits June 1, 2019 00:57

Update ammo.json

200a19f

Update professions.json

89775d3

anothersimulacrum reviewed Jun 1, 2019

View reviewed changes

krekeler0 changed the title ~~Secondtestbranch~~ rpg dice Jun 1, 2019

Update ammo.json

22b056b

ZhilkinSerg self-assigned this Jun 1, 2019

ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Jun 1, 2019

Leland reviewed Jun 1, 2019

View reviewed changes

Update SUS_specific_use_storage_items.json

f6e41ba

krekeler0 added 4 commits June 1, 2019 13:15

Update SUS_specific_use_storage_items.json

1fa951f

Update ammo.json

6de8c38

Update ammo.json

d248b28

Update SUS_specific_use_storage_items.json

c0bce1a

anothersimulacrum reviewed Jun 1, 2019

View reviewed changes

krekeler0 added 4 commits June 1, 2019 22:53

Update professions.json

90bb809

Update ammo.json

e8b0754

Update SUS_specific_use_storage_items.json

a8ad9a9

Update professions.json

3dd089f

krekeler0 changed the title ~~rpg dice~~ RPG dice WIP Jun 2, 2019

krekeler0 added 4 commits June 2, 2019 13:32

Update basement_game.json

8e689b6

Update mall_item_groups.json

41ae7cc

Update misc.json

c0f1b0a

Update item_groups.json

f740088

Update monster_drops.json

e5453a4

krekeler0 changed the title ~~RPG dice WIP~~ RPG dice Jun 3, 2019

krekeler0 closed this Jun 5, 2019

krekeler0 reopened this Jun 5, 2019

krekeler0 and others added 5 commits June 5, 2019 14:56

Update materials.json

d9d94f4

Update ammo.json

a5c7da4

Update materials.json

3d86d76

Update materials.json

cb48100

Add die use action

a8a876b

krekeler0 changed the title ~~RPG dice~~ RPG dice WIP Jun 6, 2019

krekeler0 changed the title ~~RPG dice WIP~~ RPG dice WIP do not merge Jun 6, 2019

Merge pull request #1 from anothersimulacrum/die-use-action

0f77bd9

Add die use action

AMurkin reviewed Jun 7, 2019

View reviewed changes

Night-Pryanik reviewed Jun 7, 2019

View reviewed changes

ZhilkinSerg removed their assignment Jun 7, 2019

anothersimulacrum and others added 2 commits June 7, 2019 11:11

Adjust use action a bit

395c15e

Merge pull request #2 from anothersimulacrum/die-use-action

bc66146

Adjust use action a bit

anothersimulacrum reviewed Jun 7, 2019

View reviewed changes

src/item.cpp Outdated Show resolved Hide resolved

krekeler0 and others added 2 commits June 7, 2019 18:01

Update src/item.cpp

c686951

Co-Authored-By: anothersimulacrum <[email protected]>

Update materials.json

4d84415

anothersimulacrum reviewed Jun 10, 2019

View reviewed changes

Update materials.json

eccbd84

krekeler0 mentioned this pull request Jun 10, 2019

Zinc WIP do not merge #31217

Closed

krekeler0 changed the title ~~RPG dice WIP do not merge~~ RPG dice Jun 10, 2019

kevingranade merged commit 8001c32 into CleverRaven:master Jun 11, 2019

krekeler0 deleted the secondtestbranch branch June 12, 2019 18:01

cake-pie mentioned this pull request Dec 29, 2022

Fix some metal material thermochemical properties #62927

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RPG dice #31031

RPG dice #31031

krekeler0 commented Jun 1, 2019 •

edited

Loading

anothersimulacrum Jun 1, 2019 •

edited

Loading

krekeler0 Jun 1, 2019

anothersimulacrum Jun 1, 2019

KorGgenT Jun 1, 2019

Rivet-the-Zombie commented Jun 1, 2019

YukariMindGap commented Jun 1, 2019

I-am-Erk commented Jun 1, 2019

ghost commented Jun 1, 2019

Leland Jun 1, 2019

Leland Jun 1, 2019

I-am-Erk Jun 1, 2019 •

edited

Loading

Leland Jun 1, 2019

anothersimulacrum commented Jun 1, 2019

anothersimulacrum Jun 1, 2019

krekeler0 Jun 2, 2019

egorzaderiy commented Jun 5, 2019

anothersimulacrum commented Jun 6, 2019 •

edited

Loading

AMurkin Jun 7, 2019

anothersimulacrum Jun 7, 2019

Night-Pryanik Jun 7, 2019

anothersimulacrum Jun 7, 2019

anothersimulacrum Jun 10, 2019

krekeler0 Jun 10, 2019

adamkad1 commented Jun 12, 2019

	"description": "Some dice used to play various role playing games, coming in several shapes and sizes",
	"description": "A die often used to play various role-playing games",

	"items": [ "jeans", "tshirt", "socks", "sneakers", "mbag", "pizza_cheese", "cola", "dnd_handbook", "wristwatch", "rpg_dice" ],
	"items": [ "jeans", "tshirt", "socks", "sneakers", "mbag", "pizza_cheese", "cola", "dnd_handbook", "wristwatch", "RPG_dice" ],

	string_format( _( "* This item can be used as a <info>die</info>, and has %s sides." ),
	string_format( _( "* This item can be used as a <info>die</info>, and has <info>%s</info> sides." ),

RPG dice #31031

RPG dice #31031

Conversation

krekeler0 commented Jun 1, 2019 • edited Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Additional context

anothersimulacrum Jun 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rivet-the-Zombie commented Jun 1, 2019

YukariMindGap commented Jun 1, 2019

I-am-Erk commented Jun 1, 2019

ghost commented Jun 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

I-am-Erk Jun 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anothersimulacrum commented Jun 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egorzaderiy commented Jun 5, 2019

anothersimulacrum commented Jun 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamkad1 commented Jun 12, 2019

krekeler0 commented Jun 1, 2019 •

edited

Loading

anothersimulacrum Jun 1, 2019 •

edited

Loading

I-am-Erk Jun 1, 2019 •

edited

Loading

anothersimulacrum commented Jun 6, 2019 •

edited

Loading