Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit the elec_jackhammer power drain #31192

Merged

Conversation

RosieMcCattail
Copy link
Contributor

@RosieMcCattail RosieMcCattail commented Jun 6, 2019

SUMMARY: Balance "Edit elec_jackhammer power requirements"

Purpose of change

Currently the electric jackhammer drains 25 charges per operation, that can last for up to an hour. This is about the same as the flashlight drains, if not less, though the jackhammer is quite a power hungry piece of hardware.

Describe the solution

Change the electric jackhammer to be a UPS-compatible device with 7000 max charge and 3500 charges per operation and editing the recipe accordingly to require a UPS device and a battery.

Describe alternatives you've considered

  • Actually making the jackhammer drain 1 power per X turns, though I'm not sure how to do this and how this is going to work.

Currently the electric jackhammer drains 25 charges per operation, that can last for up to an hour. This is about the same as the flashlight drains, if not less. Upping the power requirement ten times will probably be a bit closer to the reality.

Alternatives:
- Upping the drain to 500 or 100 charges, but this won't fit cleanly with the existing battery cells, with 250 one can drain the cell dry after a couple uses, with no charges left.
- Changing the battery capacity to be cleanly divided by 500 or 1000, then changing the jackhammer's drain to those values.
- Actually making the jackhammer drain 1 power per X turns, though I'm not sure how it will work.
@I-am-Erk
Copy link
Member

I-am-Erk commented Jun 7, 2019

I'm sure you are correct that the power draw is too low, but can you find an actual source on electric jackhammer power needs?

A quick search suggests that they use ~1200-2200W motors. That would be around say 1.5kJ (battery charges) per second. How long does an operation with the jackhammer usually take? I assume for, say, a one hour job you're not jackhammering all the time, but most of it. That's maybe 60 charges per minute of operation then, and 3600 per hour, which assumes you're actively jackhammering about 2/3 of the time.

These numbers are for jackhammers that can do the demolition our hammers can. Really, they are almost never run on batteries for good reason.

@RosieMcCattail
Copy link
Contributor Author

RosieMcCattail commented Jun 7, 2019

Unfortunately, that's true. If the main goal for this is to be realistic then we can probably set the power drain to 2500 so that it can be powered by a full car battery. Other than that, you can realistically power it with an atomic medium battery or atomic hevay battery. Also bionic power via UPS, but that's too complex, nobody's going to use the electric jackhammer then.

In other words, for the electric jackhammer to use heavy batteries, it should use no more than 1000 charges per operation. Either we'll have to live with that, or it couldn't be powered by those.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items: Battery / UPS Electric power management Game: Balance Balancing of (existing) in-game features. labels Jun 7, 2019
@RosieMcCattail
Copy link
Contributor Author

RosieMcCattail commented Jun 7, 2019

Alright, here's the alternative solution that might be better. The jackhammer now runs on UPS with an internal cell that's made out of a medium storage battery with a capacity of 7000 charges. I've also upped the weight of the jackhammer to correspond sort of, but the problem is that real life jackhammers have an external power supply and generally weigh 25-30 kg. Adding a weight of a medium battery to that will effectively restrict players from using the jackhammer, so maybe 40 kg will be a bit more reasonable gameplay-wise (at least until one can wear a magazine like a backpack and still use the item).

As for the power needs, @I-am-Erk is correct. They are huge.
If we take the power need per operation to be 3500 charges, then (assuming that most wall-breaking operations last half an hour), the jackhammer would have a 1944 Watt motor, which fits nicely into the real life range. The 1944 Watt motor consumes 7000 kJ per hour, or 3500 kJ per half an hour of wall demolishing.

Overall this makes an electric jackhammer quite a power hungry monster and may encourage the players to go for the gasoline-powered one.

P.S. i'm not sure if the recipe should use the whole UPS item or just the conversion mod.

@kevingranade kevingranade merged commit 74f7d04 into CleverRaven:master Jun 13, 2019
Davi-DeGanne added a commit to Davi-DeGanne/Cataclysm-DDA that referenced this pull request Nov 28, 2019
CleverRaven#35456 was poorly reviewed and a significant tweak to electric
jackhammers was included with no justification given.
This flew in the face of the carefully considered overhaul in CleverRaven#31192.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game: Balance Balancing of (existing) in-game features. Items: Battery / UPS Electric power management [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants