-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Politician profession #31119
Merged
+26
−0
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8c9d5c0
Add new Politician profession
Kanexan 4b644bd
Update data/json/professions.json
Kanexan 0e9f222
Update data/json/professions.json
Kanexan cbe21d0
Update professions.json
Kanexan 2e15768
Update professions.json
Kanexan b4aef65
Update professions.json
Kanexan 31836ee
Update professions.json
Kanexan d3ce2d2
Update professions.json
Kanexan 0db40e3
Update professions.json
Kanexan 9aa07b5
Update professions.json
Kanexan dbc4d24
Update professions.json
Kanexan 7954782
Update professions.json
Kanexan f9612dc
Update professions.json
Kanexan a6bdf70
Update professions.json
Kanexan c17fe09
Update professions.json
Kanexan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove the empty line after this when you lint, that's why it shows the red error sign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So put in one empty line—3744, which will be blank—and that will fix the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that will fix it. It threw me for a loop on my first PR too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to add the square bracket to end the .json on the last line (not including the very last line being a blank) the last curly you have ends definition of the new profession.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I think that I've done all that right, so with luck this should solve everything. I sure hope it does, anyways.