Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Politician profession #31119

Merged
merged 15 commits into from
Jun 11, 2019
32 changes: 31 additions & 1 deletion data/json/professions.json
Original file line number Diff line number Diff line change
@@ -3709,5 +3709,35 @@
},
"female": [ "chestwrap" ]
}
},
{
"type": "profession",
"ident": "politician",
"name": "Career Politician",
"description": "You've spent your life appealing to the people, persuading many and promising much throughout your time in office. Now that your voting base wants to eat you alive, winning hearts and minds just got that much harder.",
"points": 4,
"skills": [
{ "level": 4, "name": "barter" },
{ "level": 6, "name": "speech" }
],
"traits": [
"LIAR"
],
"items": {
"both": [
"suit",
"tieclip",
"sock_wool",
"dress_shoes",
"smart_phone",
"gold_watch",
"briefcase",
"skinny_tie",
"file",
"ref_lighter",
"cigar"
],
"male": [ "boxer_shorts" ],
"female": [ "bra", "panties" ]
}
]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the empty line after this when you lint, that's why it shows the red error sign.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So put in one empty line—3744, which will be blank—and that will fix the issue?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that will fix it. It threw me for a loop on my first PR too

Copy link

@ghost ghost Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add the square bracket to end the .json on the last line (not including the very last line being a blank) the last curly you have ends definition of the new profession.

Copy link
Contributor Author

@Kanexan Kanexan Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I think that I've done all that right, so with luck this should solve everything. I sure hope it does, anyways.