Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Politician profession #31119

Merged
merged 15 commits into from
Jun 11, 2019
Merged

Conversation

Kanexan
Copy link
Contributor

@Kanexan Kanexan commented Jun 4, 2019

Summary

SUMMARY: Features "This adds a new starting profession to the game, Career Politician"

Purpose of change

This change adds a new starting profession which starts with the Skilled Liar trait plus Bartering 4 and Speaking 6, as well as a suit and tie, dress shoes, a tieclip, a set of gender-variable underwear, a briefcase, a UPS cell phone, one file, a cigar, a gold watch, and a refillable lighter. It costs 4 points.

This adds a new starting profession:, "Career Politician", which starts with Bartering 2 and Speech 3.
Kanexan and others added 2 commits June 4, 2019 01:15
@Night-Pryanik
Copy link
Contributor

This is almost a copy of a Lawyer profession, with one more point in both barter and speech and slightly better starting items. If this profession is going to get in the game, at least increase its cost.

Honestly I don't see much need for this profession, if only for roleplay reasons.

@Kanexan
Copy link
Contributor Author

Kanexan commented Jun 4, 2019

That's fair; I thought that aside from the roleplaying reasons, the bartering and speech might become useful when dealing with NPCs, once they've been more fleshed out. I'll come back and try to rebalance it in the morning.

@Rail-Runner
Copy link
Contributor

Well, in that case it might get higher skill levels along with higher cost.

@DemAvalon
Copy link
Contributor

it needs to have skilled liar as its profession trait.

@jeremyshannon
Copy link
Contributor

Yeah, the joke goes that a lawyer is the larval form of a politician. This should definitely be a higher skilled, better equipped, (+ skilled liar) more costly version of lawyer, like bionic prepper is to prepper. Now that factions are becoming real, having a profession designed to schmooze NPCs into allies from day one makes sense.

@Ilysen
Copy link
Contributor

Ilysen commented Jun 5, 2019

@DemAvalon I came into this pull request hoping to see a comment like this. Posthaste!

@Kanexan
Copy link
Contributor Author

Kanexan commented Jun 5, 2019

Alright, I've updated this profession; it's now both more expensive and slightly better equipped, as well as significantly more skilled.
Plus the Career Politician now has Skilled Liar, a glaring omission that has now been rectified.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Jun 5, 2019
@ghost
Copy link

ghost commented Jun 5, 2019

Profession needs a lint: http://dev.narc.ro/cataclysm/format.html

@ghost
Copy link

ghost commented Jun 7, 2019

You need to modify the summary line in your first post to match the template.
SUMMARY: Balance "Player's weight varies with BMI and size"
for example ^

@ghost
Copy link

ghost commented Jun 8, 2019

Lint again, please

}
]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the empty line after this when you lint, that's why it shows the red error sign.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So put in one empty line—3744, which will be blank—and that will fix the issue?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that will fix it. It threw me for a loop on my first PR too

Copy link

@ghost ghost Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add the square bracket to end the .json on the last line (not including the very last line being a blank) the last curly you have ends definition of the new profession.

Copy link
Contributor Author

@Kanexan Kanexan Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I think that I've done all that right, so with luck this should solve everything. I sure hope it does, anyways.

@ZhilkinSerg ZhilkinSerg self-assigned this Jun 10, 2019
@ZhilkinSerg ZhilkinSerg merged commit 0bc2c20 into CleverRaven:master Jun 11, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jun 11, 2019
@Kanexan Kanexan deleted the New-Professions branch July 23, 2019 15:56
@Kanexan Kanexan restored the New-Professions branch July 23, 2019 15:56
@Kanexan Kanexan deleted the New-Professions branch July 23, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants