-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Politician profession #31119
Conversation
This adds a new starting profession:, "Career Politician", which starts with Bartering 2 and Speech 3.
Co-Authored-By: Rail-Runner <[email protected]>
Co-Authored-By: Rail-Runner <[email protected]>
This is almost a copy of a Honestly I don't see much need for this profession, if only for roleplay reasons. |
That's fair; I thought that aside from the roleplaying reasons, the bartering and speech might become useful when dealing with NPCs, once they've been more fleshed out. I'll come back and try to rebalance it in the morning. |
Well, in that case it might get higher skill levels along with higher cost. |
it needs to have skilled liar as its profession trait. |
Yeah, the joke goes that a lawyer is the larval form of a politician. This should definitely be a higher skilled, better equipped, (+ skilled liar) more costly version of lawyer, like bionic prepper is to prepper. Now that factions are becoming real, having a profession designed to schmooze NPCs into allies from day one makes sense. |
@DemAvalon I came into this pull request hoping to see a comment like this. Posthaste! |
Alright, I've updated this profession; it's now both more expensive and slightly better equipped, as well as significantly more skilled. |
Profession needs a lint: http://dev.narc.ro/cataclysm/format.html |
You need to modify the summary line in your first post to match the template. |
Lint again, please |
data/json/professions.json
Outdated
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove the empty line after this when you lint, that's why it shows the red error sign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So put in one empty line—3744, which will be blank—and that will fix the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that will fix it. It threw me for a loop on my first PR too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to add the square bracket to end the .json on the last line (not including the very last line being a blank) the last curly you have ends definition of the new profession.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I think that I've done all that right, so with luck this should solve everything. I sure hope it does, anyways.
Summary
SUMMARY: Features "This adds a new starting profession to the game, Career Politician"
Purpose of change
This change adds a new starting profession which starts with the Skilled Liar trait plus Bartering 4 and Speaking 6, as well as a suit and tie, dress shoes, a tieclip, a set of gender-variable underwear, a briefcase, a UPS cell phone, one file, a cigar, a gold watch, and a refillable lighter. It costs 4 points.