Fixed npcs turning hostile #29251
Merged
Fixed npcs turning hostile #29251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed npcs turning hostile"Purpose of change
Fixes #29246
Introduced in #29182
Describe the solution
Stopped NPCs forming a new opinion when dialogue is started.
This will reduce the functionality of #29246 a little bit, but that can be worked around later.
Describe alternatives you've considered
N/A
Additional context
I couldn't reproduce either before or after the change, even though I'm 90% sure it is the cause.
Probably because in that save, it was an NPC who had already formed an opinion ( when spawned ) , and then Player became scarier somehow in the meantime, the code changed and then the NPC became scared/angry when new dialogue started.