Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset follower NPC disposition/faction on player death #29182

Merged
merged 1 commit into from Apr 1, 2019
Merged

Reset follower NPC disposition/faction on player death #29182

merged 1 commit into from Apr 1, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2019

Summary

SUMMARY: Bugfixes "Reset follower NPC disposition/faction on player death"

Purpose of change

Fixes #28113

Describe the solution

When player dies, all NPC followers have their disposition and mission for talk topics, and faction and attitude reset to a somewhat blank slate ( like a dynamic NPC - but with no chance of hostility, incase new player in same world spawns in same refugee centre as previous )
Follower list will be cleared, and if you meet the same NPC in the same world with a new player, they will need to be recruited again.

To facilitate this, I have made two small chagnes to the mechanics of NPCs - one - their disposition is set when starting dialogue, ( normally NPCS have disposition set to player when spawned - these NPCS arent being spawned and the player has changed. )

Also , I have added NPCs you recruit to the players faction, and removed when player dies, this will have beneficial knock-on effects to further work on factions in general.

Describe alternatives you've considered

N/A

Additional context

N/A

@mlangsdorf mlangsdorf added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Apr 1, 2019
@ZhilkinSerg ZhilkinSerg merged commit 6e81f56 into CleverRaven:master Apr 1, 2019
@ghost ghost deleted the npc_reset_disposition branch April 2, 2019 11:19
@ghost ghost mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPC save their attitude towards player after his death
2 participants