npctalk: u/npc_add_effect takes int or string durations #27706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
NPC / Factions
|
jenkins rebuild |
This was referenced Jan 18, 2019
I-am-Erk
reviewed
Jan 18, 2019
i-am-erk got confused and thought that the "duration" value for npc_add_effect needed to be a string even if the string wasn't "PERMANENT". It didn't, but go ahead and change the code to accept integer values encoded as strings.
mlangsdorf
force-pushed
the
npc_add_effect_fix
branch
from
d537db8 to
7ed2053
Compare
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "npctalk: u/npc_add_effect takes int or string durations"Purpose of change
i-am-erk got confused and thought that the "duration" value for npc_add_effect needed to be a string even if the string wasn't "PERMANENT". It didn't, but go ahead and change the code to accept integer values encoded as strings.
Describe the solution
if "duration" is a string, read it as a string and then check if it is "PERMANENT". If it isn't, use std::stoi to convert it to an integer and pass to the set function normally.