Clarify durations in NPCs.md #27704
Merged
Clarify durations in NPCs.md #27704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds examples.
|
Since #27706 is a better solution to this, can you delete the doc text change but keep the new examples? |
mlangsdorf
added
<Documentation>
|
Yep, as soon as I'm at a desktop computer |
fix to allow mlangsdorf's changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds examples.
Summary
SUMMARY: Bugfixes "Fixes documentation of 'duration' feature in NPCs.md"Purpose of change
The issue caused in #27699 is related to a mistake I made on a lot of my earlier NPCs, where I added durations as described in the documentation, which was incorrect.
Describe the solution
Clarified in documentation that duration is not optional, and that the only permitted string is "PERMANENT", other durations passed are integers.
Also added examples, because examples are good.