Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no craft speed penalty for low morale, only a stonewall at -50 morale.
Changed to craft speed penalty for low morale.
The formula is as follows:
2 * requirement / crafter_skill
1.0f + ( -effective_morale / 50.0f )
The crafting speed is recalculated every single turn. This crafting speed also includes light penalty.
Important note: this change also means that losing light during crafting will now stop the activity!
The intentions are:
skill > 2 * requirement
)[CR] because both the formula and the intentions may be wrong.
Performance isn't perfect (it could be cached), but this shouldn't be costly enough to be noticeable, not even when repeated every single turn.
[WiP] because at the moment the penalty is applied twice - once for job length (at start of activity), once during crafting.