Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting interrupted by light going out cannot be resumed #23569

Closed
Siyalatas opened this issue Apr 21, 2018 · 1 comment
Closed

Crafting interrupted by light going out cannot be resumed #23569

Siyalatas opened this issue Apr 21, 2018 · 1 comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Milestone

Comments

@Siyalatas
Copy link
Contributor

Game version: f275932 (self-compiled)
Operating system: Manjaro Linux
Tiles or curses: Tiles
Mods active: none

Pull #23299 made light going out interrupt crafting, however crafting interrupted this way cannot be resumed, only restarted.

To test, I debug wished enough items to make a kabuto (10 hr craft), got debug HVAC and Life Support so morale doesn't fluctuate, started the craft at 14:00h, light went out at 19:50h. Wished an atomic lamp and restarted with "-", crafting didn't finish until 5:50h the next day. Same problem with selecting the recipe again in the crafting menu.

@Night-Pryanik Night-Pryanik added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Apr 22, 2018
@kevingranade kevingranade added this to the 0.D milestone Apr 27, 2018
@l29ah
Copy link
Contributor

l29ah commented Apr 28, 2018

Maybe the interruption should be done like in game::cancel_activity_query and not act->set_to_null()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

No branches or pull requests

4 participants