Destroyed cargo part fix #10746
Merged
Destroyed cargo part fix #10746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
force-pushed
the
destroyed-cargo-part-fix
branch
from
ba48cd0 to
4b6d466
Compare
|
Rebased on top of BevapDin's pointfull PR. |
Rivet-the-Zombie
added a commit
that referenced
this pull request
Jan 6, 2015
Destroyed cargo part fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two crash bugs when processing active items in vehicles. Fixes #10659
The first has not been reported, and happens when an active item is present in a vehicle cargo part when the part is destroyed (not just smashed, broken off the vehicle). To reproduce put some meat or something in a vehicle cargo part (e.g. a bicycle basket) then smash said part with a sledgehammer.
The second occurs when an active items iterator is invalidated during item processing. The invalidation is expected due to explosions and such, and there was an error in the code intended to handle it. There's a save in #10659 that reproduces this, but I didn't triage what exactly was causing it, just that this fixes it.