Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade Menu - Sorting and Inventory Problems - too many items #53057

Closed
estebandellasilva opened this issue Nov 27, 2021 · 5 comments
Closed

Trade Menu - Sorting and Inventory Problems - too many items #53057

estebandellasilva opened this issue Nov 27, 2021 · 5 comments
Labels
Info / User Interface Game - player communication, menus, etc. NPC / Factions NPCs, AI, Speech, Factions, Ownership stale Closed for lack of activity, but still valid.

Comments

@estebandellasilva
Copy link

Describe the bug

With the change to the new trade window 2 Problems became more apparent.

Frist: Sorting inventory into categories only works if the items are in the inventory of the character.
This means a soon as you sell more stuff to them and they drop stuff on the ground you, and they restock you need to know what you are looking for as it is becoming harder and harder to find

Second : NPC Restock, which iss intended - but they never consume stuff you sell them which also leads to the problem mentioned above. This could lead to the trader sooner or later be unable to offer his stuff as he could be outside the range of the item he can offfer. ( had this issue with the free traders at the hub because they hunted one of the hubspies and ran away from some of his stuff he could sell me)

Steps to reproduce

Find a trader (hub, refugee center)
Sell him stuff
wait for him to restock
see that now the inventory gets bigger and if stuff is on the ground its no longer sorted

Expected behavior

Maybe apply sorting to all of the inventory he is offering?

But as it stands currently NPC traders get overwhelmed by their items sooner or later.
NPCs need a way to get rid of Items without the Player involvement.

Screenshots

First Page everything ok
image
Second page no longer sortet after categories
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: b0e629c [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

No response

andrei8l added a commit to andrei8l/Cataclysm-DDA that referenced this issue Nov 27, 2021
@andrei8l
Copy link
Contributor

It definitely makes sense for a shopkeeper's items to always be categorized, but I'm not so sure about an NPC's or the player's items. What do you think? I think that would need an additional column (for location) that would make this UI a lot more awkward without arbitrary & selectable sorting (like in the AIM).

@wapcaplet wapcaplet added Info / User Interface Game - player communication, menus, etc. NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Nov 27, 2021
@estebandellasilva
Copy link
Author

When trading, what use do i get from the information of the location of the item? Even if i where interessted in stealing the view Menu would probably be easier than the trade window for accessing the information

@Lord-Helmchen
Copy link

Lord-Helmchen commented Dec 9, 2021

But as it stands currently NPC traders get overwhelmed by their items sooner or later.
NPCs need a way to get rid of Items without the Player involvement.

The same conclusion was also mentioned in #46766 (comment)_

this ist the crux of the matter. especially since the stuff I sell is probably not what I want to buy later.
It could be assumed that , given time, the trader can get rid of things he bought from me (probably at a profit, otherwise why would they buy it in the first place? or if they are a collector, moving it to their personal vault or something).
and as there is no way to remove items on the ground via debug, this can't even be handwaved until it is solved somehow :-(

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jan 9, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@andrei8l
Copy link
Contributor

andrei8l commented Dec 6, 2022

Consumption and restocking was fixed in #56720 and follow-ups
Sorting by category was fixed in #58917 and #62423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. NPC / Factions NPCs, AI, Speech, Factions, Ownership stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

4 participants