Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action highlights are rendered offset after sidebar changes #29256

Closed
ralreegorganon opened this issue Apr 3, 2019 · 1 comment · Fixed by #29359
Closed

Action highlights are rendered offset after sidebar changes #29256

ralreegorganon opened this issue Apr 3, 2019 · 1 comment · Fixed by #29359
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.

Comments

@ralreegorganon
Copy link
Contributor

Describe the bug
Certain actions (e.g. examine, open) call choose_adjacent_highlight which highlights the locations that can be interacted with for that action when in Curses mode. Following the sidebar changes, this highlight is offset.

To Reproduce
Steps to reproduce the behavior:

  1. Use Curses mode
  2. Stand next to a door
  3. Press the key to open a door (default o)
  4. Notice that the highlight is offset

Expected behavior
The highlight should be drawn in the same location as the thing being highlighted.

Screenshots
before
image

after, notice the brown + offset to the right
image

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version: 0.D-1371-g46cfae9ca7
  • Graphics version: Tiles (with tiles disabled in the options menu)
  • Mods loaded: default
@ralreegorganon ralreegorganon added <Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. labels Apr 3, 2019
@ralreegorganon ralreegorganon mentioned this issue Apr 3, 2019
Merged
@reed501
Copy link
Contributor

reed501 commented Apr 4, 2019

I think this might be the same issue as #29186

@Zireael07 Zireael07 mentioned this issue Apr 4, 2019
Closed
reed501 added a commit to reed501/Cataclysm-DDA that referenced this issue Apr 7, 2019
@reed501
Realigns action highlights in ASCII
1724595 
After the sidebar update, ASCII versions had lots of highlights off
center. This adds the sidebar offset onto the highlight. They were
shifted off to the right due to the new sidebar changes. Things
affected: open, close, examine, maybe more.

closes CleverRaven#29256
@reed501 reed501 mentioned this issue Apr 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ascii offset fixes reed501/Cataclysm-DDA
2 participants
@ralreegorganon @reed501