Make N3 Gas Claims look like Gas Claims on the Activity Page #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@comountainclimber I'm not sure how to get the checks to run remotely. Everything passes locally. |
|
@jseagrave21 this is awesome thanks for contributing!! I has some minor feedback, basically I think we can get away with making the No idea whats going on with CI but hopefully when you push up another commit it will trigger the test suite. NICE WORK 🤩 |
|
@comountainclimber thank you! I agree. I followed the example from the |
comountainclimber
approved these changes
Mar 20, 2023
|
🎉 nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
#2424
What problem does this PR solve?
Makes N3 Gas Claims look like Gas Claims on the Activity page
How did you solve this problem?
Updated
transactionHistoryActionsto look for a Gas Claim, then it updates themetadataso the current code sees it as a Gas Claim. Then I addedN3ClaimAbstractso it looks right on the Activity Page.How did you make sure your solution works?
yarn devtesting and verification with the unit test.Are there any special changes in the code that we should be aware of?
No.
Is there anything else we should know?
This change does not fully update the tx
metadata. I only updated enough to make the tx look like it should on the Activity page.