Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas claim in activity tab is shown as 0 NEO transfer #2424

Closed
ixje opened this issue Aug 29, 2022 · 5 comments
Closed

Gas claim in activity tab is shown as 0 NEO transfer #2424

ixje opened this issue Aug 29, 2022 · 5 comments

Comments

@ixje
Copy link
Member

ixje commented Aug 29, 2022

Wallet version or commit SHA:
Version 2.12.11 (2.12.11.8902)

Environment:
OSX

Reproduction steps:

  1. claim gas in the wallet tab
  2. look at the entry in the activity tab

The activity tab seems to be able to identify "vote" and "transfer" events, but not a gas claim event. This is probably because a claim action creates a transaction with 2 notifications

  1. a 0 neo transfer from self to self (which is what the activity row shows)
  2. a x GAS transfer from null to self

We know the exact conditions for a "claim" event, so I think we should identify this and show the amount claimed with a "claim" type instead of what we have now.

@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity. It will be automatically closed in 7 days from now if no activity is detected.

@github-actions github-actions bot added the stale label Oct 29, 2022
@ixje ixje removed the stale label Oct 31, 2022
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity. It will be automatically closed in 7 days from now if no activity is detected.

@github-actions github-actions bot added the stale label Dec 31, 2022
@ixje ixje removed the stale label Dec 31, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

This issue is stale because it has been open for 14 days with no activity. It will be automatically closed in 7 days from now if no activity is detected.

@github-actions github-actions bot added the stale label Mar 2, 2023
@ixje ixje removed the stale label Mar 2, 2023
@jseagrave21
Copy link
Contributor

@ixje I would like to work on this but I have not been able to install neon-wallet using WSL. Do you have any tips? If I can get neon-wallet installed, I think I could resolve this issue.

@jseagrave21
Copy link
Contributor

Can this be closed?

@ixje ixje closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants