Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the "Contact Leasing Agent" section to a "Management Company" section #389

Merged
merged 20 commits into from
Aug 12, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
bf0bebe
Add management company and website to UI
anders-schneider Aug 11, 2021
9464816
Merge branch 'main' into aeschneider-contact-leasing-agent-section
anders-schneider Aug 11, 2021
af06f4a
Change to "website" text and globe icon
anders-schneider Aug 12, 2021
9807737
Merge branch 'aeschneider-contact-leasing-agent-section' of github.co…
anders-schneider Aug 12, 2021
82fc8fe
Merge branch 'main' into aeschneider-contact-leasing-agent-section
anders-schneider Aug 12, 2021
b86a5a5
Revert changes to locales/xx.json (except "website")
anders-schneider Aug 12, 2021
85e0d38
Formatting fixes
anders-schneider Aug 12, 2021
88cce2a
Override leasingAgent.contact
anders-schneider Aug 12, 2021
c671aa3
Switch to overriding dueToHighCallVolume
anders-schneider Aug 12, 2021
c801f5d
Guard showing management company by a prop
anders-schneider Aug 12, 2021
c02ef27
Add a test
anders-schneider Aug 12, 2021
afd2aee
Fix code style issues with Prettier
lint-action Aug 12, 2021
0da90d1
Make management company website link open a new tab
anders-schneider Aug 12, 2021
d2b9256
Merge branch 'aeschneider-contact-leasing-agent-section' of github.co…
anders-schneider Aug 12, 2021
1280b46
Pass in management company details in the prop
anders-schneider Aug 12, 2021
388ea85
Make managementCompany optional, fix a warning
anders-schneider Aug 12, 2021
213d7ce
Fix code style issues with Prettier
lint-action Aug 12, 2021
9358f95
Clarify test
anders-schneider Aug 12, 2021
217aefe
Rationalize checking for website
anders-schneider Aug 12, 2021
4038a2f
Only prepend http if it's not already present
anders-schneider Aug 12, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui-components/src/locales/ar.json
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@
"bn": "বাংলা"
},
"leasingAgent": {
"contact": "اتصل بوكيل التأجير",
"contact": "شركة إدارة",
"dueToHighCallVolume": "نظرًا لارتفاع حجم المكالمات ، قد تسمع رسالة.",
"name": "اسم وكيل التأجير",
"namePlaceholder": "الاسم بالكامل",
Expand Down
2 changes: 1 addition & 1 deletion ui-components/src/locales/bn.json
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@
"bn": "বাংলা"
},
"leasingAgent": {
"contact": "লিজিং এজেন্টের সাথে যোগাযোগ করুন",
"contact": "ব্যবস্থাপনা কোম্পানি",
"dueToHighCallVolume": "উচ্চ কল ভলিউমের কারণে আপনি একটি বার্তা শুনতে পারেন।",
"name": "লিজিং এজেন্টের নাম",
"namePlaceholder": "পুরো নাম",
Expand Down
2 changes: 1 addition & 1 deletion ui-components/src/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@
"bn": "বাংলা"
},
"leasingAgent": {
"contact": "Comuníquese con el agente de arrendamiento",
"contact": "Empresa de gestión",
"dueToHighCallVolume": "Debido al alto volumen de llamadas, es posible que escuche un mensaje.",
"name": "Nombre del agente de arrendamiento",
"namePlaceholder": "Nombre completo",
Expand Down
38 changes: 19 additions & 19 deletions ui-components/src/locales/general.json
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@
"bn": "বাংলা"
},
"leasingAgent": {
"contact": "Contact Leasing Agent",
"contact": "Management Company",
"dueToHighCallVolume": "Due to high call volume you may hear a message.",
"name": "Leasing Agent Name",
"namePlaceholder": "Full Name",
Expand Down Expand Up @@ -1260,20 +1260,20 @@
"allInfoWillBeVerified": "All of the information that you have provided will be verified and your eligibility confirmed. Your application will be removed from the waitlist if you have made any fraudulent statements. If we cannot verify a housing preference that you have claimed, you will not receive the preference but will not be otherwise penalized.",
"bePreparedIfChosen": "Should your application be chosen, be prepared to fill out a more detailed application and provide required supporting documents."
},
"listingFilters":{
"modalTitle":"Filter Results",
"modalHeader":"Use these options to refine your list of properties.",
"neighborhood":"Neighborhood:"
"listingFilters": {
"modalTitle": "Filter Results",
"modalHeader": "Use these options to refine your list of properties.",
"neighborhood": "Neighborhood:"
},
"eligibility": {
"progress": {
"header" : "Let's find your next home",
"header": "Let's find your next home",
"sections": {
"welcome" : "Welcome",
"bedrooms" : "Bedrooms",
"age" : "Age",
"disability" : "Disability",
"income" : "Income",
"welcome": "Welcome",
"bedrooms": "Bedrooms",
"age": "Age",
"disability": "Disability",
"income": "Income",
"section8": "Section 8"
}
},
Expand All @@ -1286,30 +1286,30 @@
"studio": "Studio",
"srCountLabel": "Bedroom count"
},
"age" : {
"age": {
"prompt": "How old are you?",
"description": "Some properties only accept individuals over 62 years of age.",
"label": "years old",
"error": "Please enter a valid age."
},
"disability" : {
"prompt" : "Do you have a disability?",
"description" : "Some properties are meant for residents with disabilities. Some homes might request proof of disability with your application.",
"disability": {
"prompt": "Do you have a disability?",
"description": "Some properties are meant for residents with disabilities. Some homes might request proof of disability with your application.",
"preferNotToSay": "Prefer not to say"
},
"income" : {
"income": {
"prompt": "What is your total household annual income?",
"description": "Include income for everyone who will be living in your household including yourself. Income includes social security, retirement accounts and wages.",
"label" : "Income range",
"ranges" : {
"label": "Income range",
"ranges": {
"below10k": "Below $10,000",
"10kTo20k": "$10,000 - $20,000",
"30kTo40k": "$30,000 - $40,000",
"40kTo50k": "$40,000 - $50,000",
"over50k": "Over $50,000"
}
},
"section8" : {
"section8": {
"prompt": "Do you have a Section 8 voucher?"
}
}
Expand Down
2 changes: 1 addition & 1 deletion ui-components/src/locales/general_OLD.json
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@
"viewMap": "View Map"
},
"leasingAgent": {
"contact": "Contact Leasing Agent",
"contact": "Management Company",
"dueToHighCallVolume": "Due to high call volume you may hear a message.",
"officeHours": "Office Hours"
},
Expand Down
2 changes: 1 addition & 1 deletion ui-components/src/locales/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@
"visitWebsite": "Truy cập %{name}"
},
"leasingAgent": {
"contact": "Liên lạc với Nhân viên Đại diện cho Thuê nhà",
"contact": "Công ty quản lý",
"dueToHighCallVolume": "Do có nhiều cuộc gọi đến, quý vị có thể nghe thấy một lời nhắn.",
"officeHours": "Giờ Làm việc"
},
Expand Down
2 changes: 1 addition & 1 deletion ui-components/src/locales/zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@
"visitWebsite": "請瀏覽 %{name}"
},
"leasingAgent": {
"contact": "聯絡租賃代理",
"contact": "管理公司",
"dueToHighCallVolume": "由於來電人數眾多,您可能會聽到訊息留言。",
"officeHours": "辦公時間"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ const LeasingAgent = (props: LeasingAgentProps) => {
? `tel:${listing.leasingAgentPhone.replace(/[-()]/g, "")}`
: ""

const managementWebsite = listing.managementWebsite ? `http://${listing.managementWebsite}` : ""

return (
<section className="aside-block">
<h4 className="text-caps-underline">{t("leasingAgent.contact")}</h4>
Expand All @@ -35,7 +37,6 @@ const LeasingAgent = (props: LeasingAgentProps) => {
{listing.leasingAgentPhone}
</a>
</p>
<p className="text-sm text-gray-700">{t("leasingAgent.dueToHighCallVolume")}</p>
</>
)}

Expand All @@ -53,6 +54,19 @@ const LeasingAgent = (props: LeasingAgentProps) => {
officeHours={listing.leasingAgentOfficeHours}
/>
)}

{listing.managementCompany && (
<>
<p className="mt-5">
<p>{listing.managementCompany}</p>
{listing.managementWebsite && (
<a href={managementWebsite}>
<p>{listing.managementWebsite}</p>
</a>
)}
</p>
</>
)}
</section>
)
}
Expand Down