Convert the "Contact Leasing Agent" section to a "Management Company" section

[anders-schneider]

Issue

Addresses #329

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

This change converts the "Contact Leasing Agent" section into a section with all the information we have about the "Management Company". (This follows #329 (comment) and the mocks; the "contact property to apply" will be a separate section.)

This change introduces two new pieces of information (when they are present): the management company name and the management website. These are displayed underneath the manager name, phone number, and email address (which were all there previously).

This change also removes the "high call volume" text since that's not in our mocks.

Screenshots:

• When all the data (except email address is present):

• When the property manager name is absent:

• When the management company and website is absent (or if we were to flip showManagementCompany to false):

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Prototype/POC (not to merge)
• This change is a refactor/address technical debt
• This change requires a documentation update
• This change requires a SQL Script

How Can This Be Tested/Reviewed?

I checked the following views for three different listings with different values for these new fields:

• Desktop View
• Mobile View

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have updated the changelog to include a description of my changes

[anders-schneider]

Hey @willrlin I'd appreciate your feedback on whether this is the right way to keep ui-components as in-sync with Exygy as possible? There are some weirdnesses (e.g. t("leasingAgent.contact") set to "Management Company") but I think this change minimizes the deviation from Exygy

[anders-schneider]

@tomgebauer Would you mind taking a look particularly at the issue where the website address overflows the box? I wonder if there are better ways to handle that (I was thinking of we could just put the text "website" or "management company website" and having that link to the actual website, but it also feels nice to show the actual url of what the person is about to click on.)

[tomgebauer]

@anders-schneider I think having the text "Website" and linking it to the URL is the simplest solution here. The heading of the module already tells the user that it's the management company, and if they really want to they can copy the URL using right-click. Is there a way top have it open in a new tab when it's clicked?

[anders-schneider]

@tomgebauer

@anders-schneider I think having the text "Website" and linking it to the URL is the simplest solution here. The heading of the module already tells the user that it's the management company, and if they really want to they can copy the URL using right-click. Is there a way top have it open in a new tab when it's clicked?

Sounds good! I've updated the screenshots above - let me know if those look like what you had in mind. And made the change to make it so that clicking "website" will open a new tab.

[willrlin]

Please remember to open a PR to contribute the ui-components portion upstream.

[willrlin]

Since that string is supplied by leasing agents, could you also open a task to validate it on input and maybe also validate it here?

[anders-schneider]

Since that string is supplied by leasing agents, could you also open a task to validate it on input and maybe also validate it here?

Done! #400