Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Release 0.9.0 #1114

Merged
merged 102 commits into from
Feb 14, 2020
Merged

Release 0.9.0 #1114

merged 102 commits into from
Feb 14, 2020

Conversation

Jokinen
Copy link
Contributor

@Jokinen Jokinen commented Feb 14, 2020

MINOR CHANGES

  • Changed eslint rules to require comma dangle
  • Added eslint-plugin-react-hooks
  • Changed language and sign out menus to be navigable with tab instead of arrow keys
  • HTML's lang attribute is now synchronized with currently selected language
  • Fixed illogical tab order on mobile version of main menu
  • Added a skip to content link for screen reader and keyboard users
  • Changed date control on the search page to allow date to be written in an input

CHANGELOG

  • #1095 Display extra question field on reservation form
  • #1096 Added ResourcePanel for genericTerms. Added react-autosize-textarea for reservationExtraQuestions.
  • #1098 Added user notificator system.
  • #1099 Changed into using runtime environment
  • #1106 Fixed searches only targeting current date
  • #1110 Fixed price being displayed for resources that don't support online payment

Kimmo Virtanen and others added 30 commits December 4, 2019 09:24
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…nternalReservationFields. Working OK on My premises but NOT WORKING on Manage Reservation.
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…into feature/VAR-234-display-extra-question-field-on-reservation-form
… where authenticated state would flash when reloading page in log in state.
Jokinen and others added 22 commits February 5, 2020 10:06
VAR-275 | Sync HTML lang attribute with application language
VAR-284 | Fix tab behaviour for mobile navigation
Previously we were resetting "visually-hidden" when we were hiding the
element with "sr-only".
Previously searches which used the time range filter only worked for
the current day. This commit implementes the previously unused date
prop.
Blocking the user from accessing datepicker with tab is too convoluted
for the benefit it provides. The previous approach was naive and didn't
work.

The datepicker should not open when the user focuses it through other
means than a click. This should mean that the datepicker doesn't open
for keyboard or screen reader users, and hence won't harm their user
experience even if we don't explicitly block users from tabbing into
it.
Previously when the use used the datepicker to select a date value the
input value would not be updated to match the new date.
Previously changing the date would not adjust the availableBetween
value. The previous date value would be retained in availableBetween
which caused the date change to not have any effect in the seach
results.
…put-with-kb

VAR-286 | Allow date to be inputted with keyboard in search
VAR-277 | Fix date filter breaking on any other date than today
Price should only show for resources that implicitly support online
payment.
VAR-321 | Fix price for resources that don't support payment
@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #1114 into master will decrease coverage by 0.65%.
The diff coverage is 52.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage   74.01%   73.35%   -0.66%     
==========================================
  Files         245      259      +14     
  Lines        3621     3930     +309     
  Branches      656      695      +39     
==========================================
+ Hits         2680     2883     +203     
- Misses        805      892      +87     
- Partials      136      155      +19
Impacted Files Coverage Δ
...ervation-cancel/ReservationCancelModalContainer.js 50% <ø> (ø) ⬆️
...servations/reservation-list/ReservationListItem.js 91.66% <ø> (ø) ⬆️
src/domain/reservation/constants.js 100% <ø> (ø) ⬆️
...ons/reservation-filters/AdminReservationFilters.js 100% <ø> (ø) ⬆️
.../modals/reservation-terms/ReservationTermsModal.js 71.42% <ø> (ø) ⬆️
src/common/calendar/legend/CalendarLegend.js 100% <ø> (ø) ⬆️
...vailability-view/timeline-groups/TimelineGroups.js 52.38% <ø> (ø) ⬆️
...shared/reservation-confirmation/ReservationForm.js 87.87% <ø> (ø) ⬆️
app/shared/form-fields/ReduxFormField.js 100% <ø> (ø) ⬆️
...ed/resource-card/info-cell/ResourceCardInfoCell.js 100% <ø> (ø) ⬆️
... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727efaf...85d68a5. Read the comment docs.

Copy link
Contributor

@tuovinensanttu tuovinensanttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Jokinen Jokinen merged commit 14deed5 into master Feb 14, 2020
@Jokinen Jokinen deleted the release/0.9 branch February 14, 2020 11:03
@Jokinen Jokinen restored the release/0.9 branch February 14, 2020 11:11
@Jokinen Jokinen deleted the release/0.9 branch February 14, 2020 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants