This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…nternalReservationFields. Working OK on My premises but NOT WORKING on Manage Reservation.
…into feature/VAR-234-display-extra-question-field-on-reservation-form
…Fields to ReservationInformationForm.
Release/0.8.1
…into feature/VAR-234-display-extra-question-field-on-reservation-form
… where authenticated state would flash when reloading page in log in state.
VAR-275 | Sync HTML lang attribute with application language
VAR-284 | Fix tab behaviour for mobile navigation
Previously we were resetting "visually-hidden" when we were hiding the element with "sr-only".
VAR-238 | Add skip to content link
Previously searches which used the time range filter only worked for the current day. This commit implementes the previously unused date prop.
Blocking the user from accessing datepicker with tab is too convoluted for the benefit it provides. The previous approach was naive and didn't work. The datepicker should not open when the user focuses it through other means than a click. This should mean that the datepicker doesn't open for keyboard or screen reader users, and hence won't harm their user experience even if we don't explicitly block users from tabbing into it.
Previously when the use used the datepicker to select a date value the input value would not be updated to match the new date.
Previously changing the date would not adjust the availableBetween value. The previous date value would be retained in availableBetween which caused the date change to not have any effect in the seach results.
…put-with-kb VAR-286 | Allow date to be inputted with keyboard in search
VAR-277 | Fix date filter breaking on any other date than today
Price should only show for resources that implicitly support online payment.
VAR-321 | Fix price for resources that don't support payment
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
- Coverage 74.01% 73.35% -0.66%
==========================================
Files 245 259 +14
Lines 3621 3930 +309
Branches 656 695 +39
==========================================
+ Hits 2680 2883 +203
- Misses 805 892 +87
- Partials 136 155 +19
Continue to review full report at Codecov.
|
tuovinensanttu
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINOR CHANGES
eslint
rules to require comma dangleeslint-plugin-react-hooks
lang
attribute is now synchronized with currently selected languageCHANGELOG