This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Replace build time environment with runtime environment #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I accidentally required |
Codecov Report
@@ Coverage Diff @@
## develop #1099 +/- ##
===========================================
+ Coverage 72.32% 72.34% +0.02%
===========================================
Files 253 253
Lines 3801 3804 +3
Branches 675 675
===========================================
+ Hits 2749 2752 +3
Misses 904 904
Partials 148 148
Continue to review full report at Codecov.
|
badrange
reviewed
Jan 28, 2020
badrange
suggested changes
Jan 28, 2020
|
I accidentally used an |
This enforces the use of comma dangle.
Jokinen
force-pushed
the
fix/test-environment
branch
from
7e4803f to
7cd4726
Compare
|
I removed the custom I cleaned the commit history on the same go. |
By using a runtime environment, the app doesn't need to be rebuild on environment changes. This change also fixes an issue we had with the test environment. The test environment only sets the environment variables for runtime. This means that we don't have access to environment variables during build time, which we assumed to be the case previously.
Jokinen
force-pushed
the
fix/test-environment
branch
from
7cd4726 to
a595e57
Compare
tuovinensanttu
approved these changes
Jan 29, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a runtime environment, the app doesn't need to be rebuild on
environment changes.
This change also fixes an issue we had with the test environment. The
test environment only sets the environment variables for runtime. This
means that we don't have access to environment variables during build
time, which we assumed to be the case previously.
Ref: VAR-235