Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove form tool from composer #1526

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix: Remove form tool from composer #1526

merged 4 commits into from
Oct 28, 2024

Conversation

jiisuominen
Copy link
Contributor

UHF-0000

This was left over from some old tests. Let's remove it.

What was done

  • helfi_form_tool_embed was removed from composer.json

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout remove-form-tool-composer
    • make fresh
  • Run make drush-cr

How to test

  • Check that site works normally. Should, because this has not been enabled in Drupal.
  • Check that code follows our standards

khalima
khalima previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer install runs just fine. 🚀

khalima
khalima previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer install runs just fine. 🚀

@hyrsky hyrsky changed the base branch from develop to dev October 25, 2024 07:14
@hyrsky hyrsky dismissed khalima’s stale review October 25, 2024 07:14

The base branch was changed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hyrsky
hyrsky approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous review was automatically dismissed when target branch changed.

@jiisuominen jiisuominen merged commit a07b95e into dev Oct 28, 2024
3 checks passed
@jiisuominen jiisuominen deleted the remove-form-tool-composer branch October 28, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyrsky hyrsky hyrsky approved these changes

@khalima khalima khalima left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiisuominen @hyrsky @khalima @hel-platta-automation