Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10456: Sosiaali-, terveys- ja pelastustoimen yleisavustus #1567

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Nov 18, 2024

UHF-10456

Adds new form Sosiaali-, terveys- ja pelastustoimen yleisavustus

What was done

  • Added necessary configs
  • Added translations

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10456
    • make fresh
  • Run make drush-cr

How to test

You can check what the translations should be in these links:

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Automatic- / Regression tests

  • This PR makes no changes that effects any tests. (This will be caught in automatic testing later on, but please, please run regression tests always on PR before asking for a review)
  • This PR passes regression tests. (make test-pw)

Copy link

sonarcloud bot commented Nov 18, 2024

@jeremysteerio jeremysteerio marked this pull request as ready for review November 22, 2024 06:29
@jeremysteerio jeremysteerio changed the title UHF-10456: Add configs UHF-10456: Sosiaali-, terveys- ja pelastustoimen yleisavustus Nov 22, 2024
Copy link
Contributor

@rpnykanen rpnykanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mäppäys vissiin pielessä kun ei kentät mene ATV:lle asti

Screenshot 2024-11-25 at 8 25 55

Copy link
Contributor

@rpnykanen rpnykanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistähän ihmeestä tämä teksti tuli tähän kenttään kun avasin lomakkeen sivun ensimmäistä kertaa

Screenshot 2024-11-25 at 8 05 27

@@ -299,6 +309,7 @@ third_party_options:
52: 'Liikunnan erityisavustus 2'
53: 'Kulttuurin ja vapaa-ajan erityisavustus 1'
54: 'Kulttuurin ja vapaa-ajan erityisavustus 2'
55: 'Sosiaali-, terveys- ja pelastustoimen yleisavustus'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tää ei oo oikein.

Tässä määritellään avustuslajit, ei hakemuskohtasia juttua. Vaikka kieltämättä ihan validi päättely tuo vois olla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants