Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] add support for taboo contract, contract interface and… #545

Merged

Conversation

akinross
Copy link
Collaborator

@akinross akinross commented Dec 6, 2023

… intra_epg contract in aci_l3out_extepg_to_contract

aci_l3out_extepg_to_contract part of the #125 issue

… intra_epg contract in aci_l3out_extepg_to_contract
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e7af57) 96.30% compared to head (67eeb74) 96.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   96.30%   96.26%   -0.05%     
==========================================
  Files         211      211              
  Lines        9748     9766      +18     
  Branches     1456     1460       +4     
==========================================
+ Hits         9388     9401      +13     
- Misses        276      281       +5     
  Partials       84       84              
Flag Coverage Δ
integration 94.65% <100.00%> (-0.01%) ⬇️
sanity 35.68% <21.73%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 181bc2a into CiscoDevNet:master Dec 15, 2023
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants