Bug fix for assignment of customProperties in the option template #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When providing a JSON encoded
data-custom-properties
attribute on the original<option>
elements, attempting to access thedataset.customProperties
later, inside of a Choices event would return an improperly encoded"[object Object]"
string instead of the expected JSON object.This PR fixes the option template attribute for data-custom-properties by using JSON.stringify() before attempting to covert customProperties into a string.
Several issues open around custom properties may be fixed by this PR.
Screenshots (if appropriate)
Types of changes
Checklist