-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-custom-properties are incorrectly parsed. #1036
Labels
Comments
codeflow-biz
pushed a commit
to codeflow-biz/Choices
that referenced
this issue
May 10, 2022
codeflow-biz
pushed a commit
to codeflow-biz/Choices
that referenced
this issue
May 11, 2022
@mtriff I'm facing the same issue. Can this MR be merged ? Thanks 👍 |
Facing the same issue. Please merge this if possible. |
Same issue! Can this get merged? |
10 tasks
Hi, we're seeing this issue when we need to pass extra fields to Fuse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If Choices is initialized on existing html option tags, the data-custom-properties value is parsed in js with .dataset['custom-properties']. However, the .dataset keys are automatically transformed to camelCase. So the custom-properties should be accessed with .dataset['customProperties'].
To Reproduce
See the data-custom-properties example on the Choices page.
The text was updated successfully, but these errors were encountered: