Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-custom-properties are incorrectly parsed. #1036

Open
codeflow-biz opened this issue May 10, 2022 · 4 comments
Open

data-custom-properties are incorrectly parsed. #1036

codeflow-biz opened this issue May 10, 2022 · 4 comments
Labels

Comments

@codeflow-biz
Copy link

Describe the bug
If Choices is initialized on existing html option tags, the data-custom-properties value is parsed in js with .dataset['custom-properties']. However, the .dataset keys are automatically transformed to camelCase. So the custom-properties should be accessed with .dataset['customProperties'].

To Reproduce
See the data-custom-properties example on the Choices page.

@MacBim
Copy link

MacBim commented Aug 10, 2022

@mtriff I'm facing the same issue.

The HTML :
image

The JS :
image

The console.log result :
image

Can this MR be merged ?

Thanks 👍

@stell
Copy link

stell commented Oct 13, 2022

Facing the same issue. Please merge this if possible.

@baspieter
Copy link

Same issue! Can this get merged?

@LC43
Copy link

LC43 commented Jun 1, 2023

Hi, we're seeing this issue when we need to pass extra fields to Fuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants