Fix Type 'ChartDataSet' does not conform to protocol 'RangeReplaceabl… #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can somebody merge this PR? iOS 16 is near and this error breaks my app. Thanks! |
|
@danielgindi I think this one is top priority if you don't mind |
|
This issue is also happening on 3.6.0 with Xcode 14 beta 6. Will merging this fix also fix it for people not on version 4.x.x? |
pmairoldi
requested changes
Aug 28, 2022
| @@ -571,4 +571,12 @@ extension ChartDataSet: RangeReplaceableCollection { | |||
| entries.removeAll(keepingCapacity: keepCapacity) | |||
| notifyDataSetChanged() | |||
| } | |||
|
|
|||
| public func replaceSubrange<C>( | |||
| _ subrange: Range<Index>, | |||
There was a problem hiding this comment.
I think if we just use Swift.Range<Index> here we don't have to rename the other Range class. I think it would be a better fix for the problem.
|
Close in favour of #486. Thanks for the contribution. |
|
#486 is seven years old and unrelated. I presume that superseding issue number is a typo? |
|
Ahhhh sorry about that it was #4861 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I got this error on xCode - beta.
Fix implemented by: