Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode 14 and Swift 5.7 compiler error #4874

Closed
wants to merge 1 commit into from
Closed

Fix Xcode 14 and Swift 5.7 compiler error #4874

wants to merge 1 commit into from

Conversation

dangthaison91
Copy link

#4823 (comment)

Issue Link 🔗

Fix compilation error with Xcode 14 and Swift 5.7
#4863 #4870 #4838 #4835

Goals ⚽

Implementation Details 🚧

This PR simply collect other fixes by several developers into one PR:

Testing Details 🔍

@dingtianran
Copy link

I can confirm this patch PR works for xcode 14 beta 3&4

Joe-BOD pushed a commit to beachbodydigital/Charts that referenced this pull request Aug 2, 2022
Update for XCode14.
c919015 
* Update for the two fixes in PR now for Charts
* Swift 5.7 - ChartsOrg#4874
* XAxis beyond Chart Dataset - ChartsOrg#4839
@crazymanish
Copy link

A friendly ping to @pmairoldi to include this PR in the upcoming release! 🙏

@Joe-BOD Joe-BOD mentioned this pull request Aug 11, 2022
Closed
@alanzeino
Copy link

In case anyone is wondering, beta 5 will likely be very similar to the 14.0 GM or public version, so this (or #4881) would be ready to land or use in your local fork of Charts.

@cc-fukazawa cc-fukazawa mentioned this pull request Aug 22, 2022
Merged
@waterskier2007
Copy link

waterskier2007 commented Aug 23, 2022 •
edited
Loading

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

@iDevPro
Copy link

iDevPro commented Aug 23, 2022

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

Which crashes ? May you show gist ?

@adityarajpt
Copy link

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

@waterskier2007 I tried on 14.5, I don't see any crash so far

@mustiikhalil mustiikhalil mentioned this pull request Aug 25, 2022
Merged
@werkaflute
Copy link

On XCode 14.6 Beta I have errors :/

@pmairoldi pmairoldi self-assigned this Aug 27, 2022
@pmairoldi
Copy link
Collaborator

Everything from this PR has been merged from other PRs. Thanks contributing!

@pmairoldi pmairoldi closed this Aug 28, 2022
@nkark
Copy link

nkark commented Aug 30, 2022 •
edited
Loading

@pmairoldi @danielgindi When will there be a new release or tag with all the changes in master? Specifically the Xcode 14 support

@pmairoldi
Copy link
Collaborator

When Xcode 14 gm is released

@alanzeino
Copy link

@pmairoldi @danielgindi When will there be a new release or tag with all the changes in master? Specifically the Xcode 14 support

change your package manager to point to the git commit and you don't need to wait for a new release or tag

@PorterHoskins
Copy link

@danielgindi Is there a plan to change the package name so we can use Apple's Charting library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iDevPro iDevPro iDevPro approved these changes

@mariuspatru mariuspatru mariuspatru approved these changes

@vmagnani vmagnani vmagnani approved these changes

Assignees

@pmairoldi pmairoldi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.