Different line width

[nRewik]

I use line chart graph. Line width at 100% is thinner than others. Please help me. Thank you.

[liuxuan30]

semms the top line is clipped. it seems your y axis range is just mapped to the whole contentRect, so drawing on the top edge causes clipping. I assume you have set axisMaxValue. By default, the range will slighly largher than 1, giving some space to draw the line.

I think there is no quick solution here, because you are drawing on the edge with clipping enabled, and line width is larger than 1

[nRewik]

I set the line chart in these two functions.

- (void)setupLineChartView {

    // Disable all interactions
    self.lineChartView.dragEnabled = NO;
    self.lineChartView.pinchZoomEnabled = NO;
    [self.lineChartView setScaleEnabled:NO];

    self.lineChartView.highlightPerTapEnabled = NO;
    self.lineChartView.highlightPerDragEnabled = NO;
    self.lineChartView.doubleTapToZoomEnabled = NO;

    self.lineChartView.borderLineWidth = 5.0;
    self.lineChartView.descriptionText = @"";

    // Legend
    self.lineChartView.legend.enabled = NO;

    // X axis
    self.lineChartView.xAxis.labelPosition = XAxisLabelPositionBottom;
    self.lineChartView.xAxis.drawGridLinesEnabled = NO;
    self.lineChartView.xAxis.labelFont = [UIFont systemFontOfSize:11.0 weight:UIFontWeightRegular];
    self.lineChartView.xAxis.labelTextColor = [UIColor colorWithRed:102/255.0 green:102/255.0 blue:102/255.0 alpha:1.0];
    self.lineChartView.xAxis.spaceBetweenLabels = 1;
    self.lineChartView.xAxis.avoidFirstLastClippingEnabled = YES;

    // Y axis
    self.lineChartView.rightAxis.enabled = NO;

    self.lineChartView.leftAxis.labelFont = [UIFont systemFontOfSize:12.5 weight:UIFontWeightSemibold];
    self.lineChartView.leftAxis.labelTextColor = [UIColor colorWithRed:151/255.0 green:151/255.0 blue:151/255.0 alpha:1.0];
    self.lineChartView.leftAxis.gridColor = [UIColor colorWithRed:151/255.0 green:151/255.0 blue:151/255.0 alpha:1.0];

    self.lineChartView.leftAxis.drawAxisLineEnabled = NO;

    [self.lineChartView.leftAxis setLabelCount:5 force:YES];

    self.lineChartView.leftAxis.granularity = 0.25;
    self.lineChartView.leftAxis.granularityEnabled = YES;

    self.lineChartView.leftAxis.drawZeroLineEnabled = NO;
    self.lineChartView.leftAxis.axisMinValue = 0.0;
    self.lineChartView.leftAxis.axisMaxValue = 1.0;

    NSNumberFormatter *percentFormatter = [[NSNumberFormatter alloc] init];
    percentFormatter.numberStyle = NSNumberFormatterPercentStyle;
    percentFormatter.roundingMode = NSNumberFormatterRoundFloor;

    self.lineChartView.leftAxis.valueFormatter = percentFormatter;

    self.lineChartView.minOffset = 20.0;
}

- (void)adjustLineChartWithKpiArray:(NSArray<NSNumber *> *)kpiArray {

    // Create data set
    NSMutableArray<ChartDataEntry *> *yVals = [NSMutableArray array];

    BOOL containsAllNoData = YES;
    for (NSInteger i=1; i<=[kpiArray count]; i++) {

        NSNumber *kpiNumber = kpiArray[i-1];
        if (![kpiNumber isEqual:[NSNull null]]) {
            containsAllNoData = NO;
        }

        BOOL noData = [kpiNumber isEqual:[NSNull null]];
        float kpi = noData ? 0.0f : [kpiNumber floatValue];

        ChartDataEntry *chartDataEntry = [[ChartDataEntry alloc] initWithValue:kpi xIndex:i];
        [yVals addObject:chartDataEntry];
    }

    if (!containsAllNoData) {

        // This check is make sure that entries can be
        // [ 0.0, 0.0, 0.0, 0.0, 0.0 ] or [ 0.0, 0.8, 0.3, 0.5 ] but not [ 0.0, 1.0, 0.0, 0.0 ]
        // remove all 0.0 behind positive value
        //
        for (NSInteger i = [kpiArray count]-1; i >= 0; i--) {
            BOOL hasData = ![kpiArray[i] isEqual:[NSNull null]];
            if (hasData) {
                break;
            }
            [yVals removeObjectAtIndex:i];
        }
    }


    LineChartDataSet *dataSet = [[LineChartDataSet alloc] initWithYVals:yVals label:@"engagement data set"];

    dataSet.axisDependency = AxisDependencyLeft;
    dataSet.drawCircleHoleEnabled = NO;
    dataSet.circleRadius = 5.0;

    dataSet.drawValuesEnabled = YES;

    NSNumberFormatter *dataSetformatter = [[NSNumberFormatter alloc] init];
    dataSetformatter.numberStyle = NSNumberFormatterPercentStyle;
    dataSetformatter.roundingMode = NSNumberFormatterRoundFloor;
    dataSet.valueFormatter = dataSetformatter;

    // Create line colors
    NSMutableArray<UIColor *> *lineColors = [NSMutableArray array];
    for (NSInteger i=1; i<[kpiArray count]; i++) {

        NSNumber *previousDayKPI = kpiArray[i-1];
        NSNumber *currentDayKPI = kpiArray[i];

        BOOL noPreviousData = [previousDayKPI isEqual:[NSNull null]];
        BOOL noCurrentData = [currentDayKPI isEqual:[NSNull null]];

        if (noPreviousData || noCurrentData) {
            [lineColors addObject:[UIColor clearColor]];
        } else {
            [lineColors addObject:[UIColor ekoThemeColor]];
        }
    }

    // Create circle colors and value colors
    NSMutableArray<UIColor*> *circleColors = [NSMutableArray array];
    NSMutableArray<UIColor*> *valueColors = [NSMutableArray array];

    for (NSNumber *kpiNumber in kpiArray) {
        BOOL noData = [kpiNumber isEqual:[NSNull null]];
        UIColor *circleColor = noData ? [UIColor ekoGrayColor] : [UIColor ekoThemeColor];
        [circleColors addObject:circleColor];

        [valueColors addObject:[UIColor colorWithRed:102/255.0 green:102/255.0 blue:102/255.0 alpha:1.0]];
    }

    dataSet.valueColors = valueColors;
    dataSet.colors = lineColors;
    dataSet.circleColors = circleColors;
    dataSet.lineWidth = 1.0f;

    // Create data
    NSArray<NSString *> *xVals = @[@"", @"Mon", @"Tue", @"Wed", @"Thu", @"Fri", @""];
    LineChartData *lineData = [[LineChartData alloc] initWithXVals:xVals dataSet:dataSet];

    self.lineChartView.data = lineData;
}

[liuxuan30]

yes I see you have specified axisMaxValue, which will force the edge to be exactly at "100%". As I said earlier, I think there is no quick solution here, because you are drawing on the edge with clipping enabled, and line width is no less than 1

[liuxuan30]

one thing could be improved is, counting the half max line width (among axis line, grid line, data set line) into account, so increase the contentRect to have enough space for lines on the edge

[nRewik]

Now there is no way to fix right ?

[liuxuan30]

I think it can be fixed as I mentioned above, but we don't have enough man power to do so right now. I want to help but a lots of things on my plate right now, so maybe later.
You are more than welcome to fix it

[mouhcine]

@danielgindi Is there gonna be a release with this fix (cocoapods version)?

[nRewik]

Have you guys fix this? I still have this issue in v3.0.0

[liuxuan30]

It's fixed in Aug 14. I checked the 3.0 code, it's there.
Would you be able to reproduce it with ChartsDemo?

[nRewik]

Yeah. I still can reproduce.

I changed the code in LineChart1ViewController a little bit.

1. change y value to show.

for (int i = 0; i < 7; i++)
{
    double val = (i % 3 == 0) ? 160 : 200.0;
    [values addObject:[[ChartDataEntry alloc] initWithX:i y:val]];
}

2. remove dash line

// set1.lineDashLengths = @[@5.f, @2.5f];
// set1.highlightLineDashLengths = @[@5.f, @2.5f];

3. change line width

set1.lineWidth = 5.0;

[VikhlyaevSergey]

Yeah. I still can reproduce.

I changed the code in LineChart1ViewController a little bit.

1. change y value to show.

for (int i = 0; i < 7; i++)
{
    double val = (i % 3 == 0) ? 160 : 200.0;
    [values addObject:[[ChartDataEntry alloc] initWithX:i y:val]];
}

1. remove dash line

// set1.lineDashLengths = @[@5.f, @2.5f];
// set1.highlightLineDashLengths = @[@5.f, @2.5f];

1. change line width

set1.lineWidth = 5.0;

How to hide bottom info??

[pxminfodev]

Is this issue resolve because i have suffer from same issue. can i get update?

[pullayya-569]

Is this issue resolve because i have suffer from same issue. can i get update?

[Thoughtyness]

I am still having this issue and found a good enough fix.

Go to one or both of:
Charts-master/Source/Charts/Renderers/XAxisRenderer.swift
Charts-master/Source/Charts/Renderers/YAxisRenderer.swift

And comment out the line "context.clip(to: self.gridClippingRect)"

I'm not sure what unintended consequences this has, but I haven't noticed anything not working.