migrate Chart v3 code in master to swift 2.3 syntax #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefully this will get travis working
update iso-snapshot-test-case to master to have the fix for now
… tagged we could change to the new version
upgrade carthage, resolve test failure config
Add missing imports for iOS 7 support
BUGFIX: fix infinite recursive call of getXIndex(_:)
2. remove brew upgrade carthage, because travis saying
remove brew upgrade carthage for travis and update ios-snapshot-test-case to 2.1.2
Typo fix, our of range => out of range
support Realm 1.0.2
fix Realm pod spec typo
* x-indices: Work on x-values instead of x-indices (free for all :-)
If more offset is needed - use extraOffsets, or adjust the maxSizePercent).
As with swift's minimal syntax - the chance of anyone referencing those by name is very low. On ObjC, the names stayed the same, for namespacing.
Sorry, un-mergable to `master`...
_displayLink might not have been created, i.e. in Interface Builder context.
|
use github 'squash and merge' option gives me more trouble. use #1389 as a clean shot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate Chart v3 code in master to swift 2.3 syntax