Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM modules demo #3183

Closed
wants to merge 1 commit into from
Closed

ESM modules demo #3183

wants to merge 1 commit into from

Conversation

dapplion
Copy link
Contributor

Motivation

Demo for #3182

So far:

  • Compiles ok. Lib code can be run be up to date Node.js versions
  • Lints ok
  • VSCode support is good. Automatically adds the .js extension to new imports and navigation through references is good
  • I'm not able to run tests tho. ts-node does not seem properly configured.

Description

Use ESM modules in utils package as a demo of how it looks like

@codeclimate
Copy link

codeclimate bot commented Sep 16, 2021

Code Climate has analyzed commit 1feb4ed and detected 0 issues on this pull request.

View more on Code Climate.

@dapplion dapplion mentioned this pull request Mar 21, 2022
Closed
@philknows philknows mentioned this pull request May 10, 2022
Closed
6 tasks
@dapplion
Copy link
Contributor Author

Closing for #3978

@dapplion dapplion closed this May 10, 2022
@dapplion dapplion deleted the dapplion/dapplion-esm-attempt2 branch May 10, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dapplion