Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodestar ecosystem to ES modules (ESM) #3863

Closed
wemeetagain opened this issue Mar 18, 2022 · 6 comments
Closed

Update lodestar ecosystem to ES modules (ESM) #3863

wemeetagain opened this issue Mar 18, 2022 · 6 comments
Assignees
Labels
epic Issues used as milestones and tracking multiple issues.

Comments

@wemeetagain
Copy link
Member

wemeetagain commented Mar 18, 2022

Once lodestar dependencies move to ES modules only, we can't upgrade unless we also move. Since ES modules are the future, we should migrate when possible.

Current progress

libp2p

bls

ssz

Related:

@dapplion
Copy link
Contributor

dapplion commented Mar 21, 2022

@philknows philknows added the epic Issues used as milestones and tracking multiple issues. label Mar 22, 2022
@philknows philknows mentioned this issue Mar 22, 2022
3 tasks
@dapplion dapplion changed the title Update lodestar ecosystem to ES modules Update lodestar ecosystem to ES modules (ESM) May 12, 2022
@philknows
Copy link
Member

@wemeetagain Does #3978 conclude the upgrades to ESM? If so, we can close this.

@wemeetagain
Copy link
Member Author

wemeetagain commented May 26, 2022

We will migrate our other libraries over to ESM too. ssz monorepo packages, bls packages, discv5, etc.
Lower priority tho, no urgency

@wemeetagain
Copy link
Member Author

wemeetagain commented Jun 30, 2022

@philknows
Copy link
Member

We should continue discussing this for https://github.com/ChainSafe/ssz

@wemeetagain
Copy link
Member Author

I don't think its worth keeping this open. There are a few libraries we maintain that are commonjs that likely can't be moved without massive pain, and there are libraries that are commonjs that are low priority to change (eg libraries using napi-rs, which currently only supports commonjs).

closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Issues used as milestones and tracking multiple issues.
Projects
Status: Done
Development

No branches or pull requests

3 participants