-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task(storage/child-trie): implement store/load of child trie from DB #2122
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2122 +/- ##
===============================================
- Coverage 61.54% 61.46% -0.09%
===============================================
Files 213 213
Lines 27469 27497 +28
===============================================
- Hits 16906 16901 -5
- Misses 8697 8721 +24
- Partials 1866 1875 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I should have made this draft. Some of the changes that I made earlier were not required after applying changes recommended by noot. @qdm12 Made changes you asked for in last two commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Sorry I didn't know it was still a drafty PR 😉 Note you can convert it back to draft even if you open it as non-draft (although people will still be notified for reviews).
Co-authored-by: Quentin McGaw <[email protected]>
…r into kishan/task/child-trie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! awesome work :D
created a separate small task, so that I can merge this now #2171
Changes
Tests
Issues
Primary Reviewer