Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement store/load of child trie from DB #1490

Closed
arijitAD opened this issue Mar 24, 2021 · 2 comments · Fixed by #2302
Closed

implement store/load of child trie from DB #1490

arijitAD opened this issue Mar 24, 2021 · 2 comments · Fixed by #2302
Assignees
@kishansagathiya
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues

Comments

@arijitAD
Copy link
Contributor

arijitAD commented Mar 24, 2021 •
edited by noot
Loading

Describe the bug

  • If GetStorageChild or GetStorageFromChild is called (in state.StorageState) It fails to load child trie from DB.
  • the trie functions Store and WriteDirty should be updated to write the child tries to the database
  • the trie function Load should be updated to load the child tries from the database and store them in memory

To Reproduce

Steps to reproduce the behavior:

  1. Clear the child trie from cache.
  2. Try to load the child trie from DB.

Log output

Log Output 
paste log output...

Specification

  • go version:
  • gossamer version:
  • gossamer commit tag:
  • gossamer commit hash:
  • operating system:
  • additional links:
@dutterbutter dutterbutter changed the title Fix load child trie from DB. Fix load child trie from DB Mar 31, 2021
@omar391 omar391 self-assigned this Sep 27, 2021
@omar391 omar391 mentioned this issue Oct 15, 2021
Closed
@noot noot added p2 and removed Type: Bug labels Nov 29, 2021
@noot noot changed the title Fix load child trie from DB implement store/load of child trie from DB Nov 29, 2021
@kishansagathiya kishansagathiya self-assigned this Dec 8, 2021
kishansagathiya added a commit that referenced this issue Dec 16, 2021
@kishansagathiya
implement store/load of child trie from DB
2cb8d55 
Fixes #1490
@kishansagathiya kishansagathiya mentioned this issue Dec 16, 2021
Merged
@danforbes danforbes reopened this Jan 11, 2022
@danforbes danforbes added the Epic Issue used to track development status of a complex feature, aggregates several issues label Jan 11, 2022
@noot
Copy link
Contributor

noot commented Jan 11, 2022

@danforbes why was this reopened?

@danforbes
Copy link
Contributor

Because I turned it into an Epic to track #2171

@noot noot mentioned this issue Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishansagathiya kishansagathiya

Labels
Epic Issue used to track development status of a complex feature, aggregates several issues
Projects
None yet
Milestone
No milestone
6 participants
@danforbes @arijitAD @kishansagathiya @omar391 @dutterbutter @noot